You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/01/16 04:49:25 UTC

[GitHub] [hudi] xushiyan edited a comment on pull request #2426: [HUDI-304] Configure spotless and java style

xushiyan edited a comment on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-760076561


   @vinothchandar @leesf @yanghua The style can be sync'ed by 
   - using google-java-format in spotless config and `spotless:apply` enforces the style that is also compatible with existing checkstyle test
   - IDE install google-java-format plugin to control the formatter to use the same style
   
   I committed 2 java files to show the diffs. The total diff will be huge, which can be solved by adding `.git-blame-ignore-revs` to ignore the formatting commits. Do the new style and the plan look good?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org