You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "LostSnowfluff (via GitHub)" <gi...@apache.org> on 2026/09/03 14:03:37 UTC

[PR] Respect update_mask in bulk connection updates [airflow]

LostSnowfluff opened a new pull request, #72486:
URL: https://github.com/apache/airflow/pull/72486

    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull request.
   Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the documentation.
   
   For user-facing UI changes, please attach before/after screenshots (or a short
   screen recording) so reviewers can assess the visual impact.
   
   Feel free to ping (in general) for the review if you do not see reaction for a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ## Description
   
   The Connections bulk update action accepts `update_mask` and documents that only
   the listed fields are applied. However, `BulkConnectionService.handle_bulk_update`
   does not pass `action.update_mask` to `update_orm_from_pydantic`.
   
   As a result, fields included in the request body but omitted from the update mask
   are still updated. For example, a request with `update_mask=["description"]` also
   changes `conn_type` when `conn_type` is present in the entity. This makes bulk
   updates inconsistent with the single-connection PATCH behavior and can modify
   fields that the caller did not intend to change.
   
   Pass `action.update_mask` to the existing ORM update helper so bulk updates apply
   the same field filtering as other update paths. Add a regression test covering a
   request that provides both `conn_type` and `description` while masking only
   `description`.
   
   No documentation changes are needed because this restores the behavior already
   described by the existing `update_mask` contract.
   
   
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (OpenAI Codex)
   
   Generated-by: OpenAI Codex following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Respect update_mask in bulk connection updates [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #72486:
URL: https://github.com/apache/airflow/pull/72486#issuecomment-5526971038

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
   - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Respect update_mask in bulk connection updates [airflow]

Posted by "LostSnowfluff (via GitHub)" <gi...@apache.org>.
LostSnowfluff commented on PR #72486:
URL: https://github.com/apache/airflow/pull/72486#issuecomment-5535622789

   I investigated this case and confirmed that the it is reproducible.
   
   The fix now checks both the shared `update_mask` and the current entity’s provided fields before updating `password` or `extra`. This prevents omitted fields from being treated as `None`, while preserving the behavior of explicitly provided `extra: null`.
   
   I also added regression tests for heterogeneous entity fields and explicit clearing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Respect update_mask in bulk connection updates [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #72486: Respect update_mask in bulk connection updates
URL: https://github.com/apache/airflow/pull/72486


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Respect update_mask in bulk connection updates [airflow]

Posted by "LostSnowfluff (via GitHub)" <gi...@apache.org>.
LostSnowfluff commented on PR #72486:
URL: https://github.com/apache/airflow/pull/72486#issuecomment-5534021197

   > The direction of this fix looks good, but other areas might need to be adjusted accordingly.
   > 
   > `update_mask` is shared across all entities, but an individual entity might not provide every field specified in the mask.
   > 
   > For example, if extra is included in the mask but omitted from one entity, this change passes the mask down to `update_orm_from_pydantic`, which ends up clearing that entity's existing extra via `set_extra(None)`.
   > 
   > Could you test whether this bug holds true? If it does, I'd suggest fixing it and adding a regression test to prevent this from happening again.
   
   Thanks for the thoughtful review. This is a very good catch.
   
   I'll investigate how the shared `update_mask` interacts with fields omitted from individual entities, and verify whether it can clear existing values when passed to `update_orm_from_pydantic`.
   
   If the issue does exist, I'll update the fix and add a regression test. Otherwise, I'll explain why this behavior does not take place. This may take some time, but I'll report back once I've completed the investigation.
   
   Thanks again for your careful feedback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Respect update_mask in bulk connection updates [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #72486:
URL: https://github.com/apache/airflow/pull/72486#issuecomment-6280380055

   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org