You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "techdocsmith (via GitHub)" <gi...@apache.org> on 2023/03/31 23:09:38 UTC
[GitHub] [druid] techdocsmith commented on a diff in pull request #13868: Add docs contribution page
techdocsmith commented on code in PR #13868:
URL: https://github.com/apache/druid/pull/13868#discussion_r1154986298
##########
docs/development/contributing-to-docs.md:
##########
@@ -0,0 +1,139 @@
+---
+id: contributing-to-docs
+title: "How to contribute to Druid docs"
+---
+
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+Druid is a [community-led project](https://druid.apache.org/community/) and we are delighted to receive contributions of anything from minor fixes to docs to big new features.
+
+Druid docs contributors:
+
+* Improve existing content
+* Create new content
+
+## Getting started
+
+Druid docs contributors can open an issue about documentation, or contribute a change with a pull request (PR).
+
+The open source Druid docs are located here:
+https://druid.apache.org/docs/latest/design/index.html
+
+Some of the Druid docs are incorporated into the Imply docs:
+https://docs.imply.io/latest/apache-druid-doc/
+
+If you need to update a Druid doc, locate and update the doc in the Druid repo, following the instructions below. Once a month, we run a script to update the Imply docs repo with recent updates to the Druid docs.
+
+## Druid repo branches
+
+The Druid team works on Apache Druid master, and then branches to 0.17, 0.18, etc and 017-iap (which stands for Imply Analytics Platform).
+
+See [CONTRIBUTING.md](https://github.com/apache/incubator-druid/blob/master/CONTRIBUTING.md) for instructions on contributing to Apache Druid.
+
+## Before you begin
+
+Before you can contribute to the Druid docs for the first time, you must complete the following steps:
+
+ 1. Fork the [Druid repo](https://github.com/apache/druid). Your fork will be the ```origin``` remote.
+ 2. Clone the Druid repo from your fork.
+ 3. Set up your remotes locally ```upstream``` in the Druid repo in ```.git/config```:
+ ~~~~
+ [remote "upstream"]
+ url = https://github.com/apache/druid.git
+ fetch = +refs/heads/*:refs/remotes/upstream/*
+ pushurl = no_push
+ [branch "master"]
+ remote = upstream
+ merge = refs/heads/master
+ [remote "origin"]
+ url = https://github.com/{my-git-id}/druid.git
+ fetch = +refs/heads/*:refs/remotes/upstream/*
+ [branch "master"]
+ remote = origin
+ merge = refs/heads/master
+ ~~~~
+
+ For ```upstream```, ```push_url = no_push``` means you won’t accidentally push to upstream.
+ Make sure to put your github id for {my-git-id}.
+ 4. ```git config --list --show-origin``` to make sure you’ve got your email configured. If you need to set your email, you can set it per repo or globally. Global instructions [here](https://docs.github.com/en/github-ae@latest/account-and-profile/setting-up-and-managing-your-github-user-account/managing-email-preferences/setting-your-commit-email-address#setting-your-commit-email-address-in-git).
+ 5. Docusaurus?
+
+## Contributing
+
+ 1. On branch ```master```, fetch the latest commit:
+
+ ~~~~
+ git fetch upstream
+
+ remote: Enumerating objects: 397, done.
+ remote: Counting objects: 100% (341/341), done.
+ remote: Compressing objects: 100% (181/181), done.
+ remote: Total 397 (delta 118), reused 255 (delta 98), pack-reused 56
+ Receiving objects: 100% (397/397), 266.19 KiB | 16.64 MiB/s, done.
+ Resolving deltas: 100% (118/118), completed with 44 local objects.
+ From https://github.com/apache/druid
+ 819d706082..6c9f926e3e 0.21.0 -> upstream/0.21.0
+ 8a3be6bccc..84aac4832d master -> upstream/master
+ * [new tag] druid-0.21.0 -> druid-0.21.0
+
+ ➜ git reset --hard upstream/master
+ HEAD is now at 84aac4832d Add feature to automatically remove rules based on retention period (#11164)
+ ~~~~
+
+ Now you're up to date.
+
+ 2. Create your working branch:
+ ~~~~
+ git checkout -b my-work
+ ~~~~
+ 3. Make your changes, add, and commit:
+ ~~~~
+ git add my-change.md
+ git commit -m "i made some changes"
+ ~~~~
+ 4. Test changes locally.
+ 5. Push your changes to your fork: ```origin```
+ ~~~~
+ git push --set-upstream origin my-work
+ ~~~~
+ 6. Go to GitHub for the Druid repo. It should realize you have a new branch in your fork. Create a pull request from your for ```my-work``` to ```master``` in the Druid repo.
+
+## Style guide
+
+Before publishing new content or updating an existing topic, audit your documentation using this checklist to make sure your contributions align with existing documentation.
+
+* Use descriptive link text. If a link downloads a file, make sure to indicate this action
+* Use present tense where possible
+* Avoid negative constructions when possible
+* Use clear and direct language
+* Use descriptive headings and titles
+* Avoid using a present participle or gerund as the first word in a heading or title
+* Use sentence case in document titles and headings
+* Don’t use images of text or code samples
+* Use SVG over PNG if available
+* Provide an equivalent text explanation with each image
+* Use the appropriate text-formatting
+* Put conditional clauses before instructions
+* Avoid gender-specific pronouns, instead use they
+* Use second person — you instead of we
+* When American spelling is different from Commonwealth/"British" spelling, use the American spelling
+* Don’t use terms considered disrespectful. Refer to the Google’s [Word list](https://developers.google.com/style/word-list) for guidance and alternatives
+* Use straight quotation marks and straight apostrophes
+* Introduce a list, a table, or a procedure with an introductory sentence
Review Comment:
@paul-rogers , can we not introduce this style now. None of the current docs follow it and I worry that it could cause confusion. For example, if someone were to edit an existing doc and use a line-breaking tool to fix their markdown, then it would possibly make the pr affect a lot more lines than they intend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org