You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/17 14:46:08 UTC

[GitHub] [arrow-datafusion] carols10cents opened a new pull request #1853: Remove allow unused imports from ballista-core, then fix all warnings

carols10cents opened a new pull request #1853:
URL: https://github.com/apache/arrow-datafusion/pull/1853


   # Which issue does this PR close?
   
   Closes #1852.
   
    # Rationale for this change
   
   I think most Rust developers expect this lint to let them know when imports are no longer needed.
   
   # What changes are included in this PR?
   
   - I removed the `allow`
   - I fixed all the warnings
   - I ran rustfmt
   
   # Are there any user-facing changes?
   
   Nope!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Jimexist merged pull request #1853: Remove allow unused imports from ballista-core, then fix all warnings

Posted by GitBox <gi...@apache.org>.
Jimexist merged pull request #1853:
URL: https://github.com/apache/arrow-datafusion/pull/1853


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1853: Remove allow unused imports from ballista-core, then fix all warnings

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1853:
URL: https://github.com/apache/arrow-datafusion/pull/1853#discussion_r809356304



##########
File path: ballista/rust/core/src/lib.rs
##########
@@ -16,7 +16,6 @@
 // under the License.
 
 #![doc = include_str!("../README.md")]
-#![allow(unused_imports)]

Review comment:
       👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org