You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/06 06:19:21 UTC
[GitHub] [rocketmq-client-go] Me1onRind opened a new pull request #373: change transaction producer about struct, interface, chan type from s…
Me1onRind opened a new pull request #373: change transaction producer about struct, interface, chan type from s…
URL: https://github.com/apache/rocketmq-client-go/pull/373
1. change TransactionListener param from struct to struct pointer
2. change CheckLocalTransaction msg member from strucut to pointer, and pass it's pointer to channel order than value
3. add judge before log error in checkTransactionState()
I just use examples/producer/transaction/main.go to test it, and I think should not hidden bugs after I test and read context code.
#340
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io commented on issue #373: change transaction producer about struct, interface, chan type from s…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #373: change transaction producer about struct, interface, chan type from s…
URL: https://github.com/apache/rocketmq-client-go/pull/373#issuecomment-571020121
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/373?src=pr&el=h1) Report
> Merging [#373](https://codecov.io/gh/apache/rocketmq-client-go/pull/373?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/2ace48afd7c054fa6231e28407f7e40f76c84ad6?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/373?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #373 +/- ##
==========================================
- Coverage 25.31% 25.31% -0.01%
==========================================
Files 47 47
Lines 5459 5460 +1
==========================================
Hits 1382 1382
- Misses 3887 3888 +1
Partials 190 190
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/373?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [primitive/message.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/373/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL21lc3NhZ2UuZ28=) | `25% <ø> (ø)` | :arrow_up: |
| [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/373/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.24% <0%> (ø)` | :arrow_up: |
| [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/373/diff?src=pr&el=tree#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `29.81% <0%> (-0.1%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/373?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/373?src=pr&el=footer). Last update [2ace48a...267c27d](https://codecov.io/gh/apache/rocketmq-client-go/pull/373?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io edited a comment on issue #373: change transaction producer about struct, interface, chan type from s…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #373: change transaction producer about struct, interface, chan type from s…
URL: https://github.com/apache/rocketmq-client-go/pull/373#issuecomment-571020121
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/373?src=pr&el=h1) Report
> Merging [#373](https://codecov.io/gh/apache/rocketmq-client-go/pull/373?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/2ace48afd7c054fa6231e28407f7e40f76c84ad6?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/373?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #373 +/- ##
==========================================
- Coverage 25.31% 25.31% -0.01%
==========================================
Files 47 47
Lines 5459 5460 +1
==========================================
Hits 1382 1382
- Misses 3887 3888 +1
Partials 190 190
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/373?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [primitive/message.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/373/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL21lc3NhZ2UuZ28=) | `25% <ø> (ø)` | :arrow_up: |
| [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/373/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.24% <0%> (ø)` | :arrow_up: |
| [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/373/diff?src=pr&el=tree#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `29.81% <0%> (-0.1%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/373?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/373?src=pr&el=footer). Last update [2ace48a...267c27d](https://codecov.io/gh/apache/rocketmq-client-go/pull/373?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] wenfengwang merged pull request #373: [ISSUE
#340] change transaction producer interface signature
Posted by GitBox <gi...@apache.org>.
wenfengwang merged pull request #373: [ISSUE #340] change transaction producer interface signature
URL: https://github.com/apache/rocketmq-client-go/pull/373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services