You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "officialasishkumar (via GitHub)" <gi...@apache.org> on 2026/05/24 09:08:09 UTC
[PR] fix(agent-service): align auto-layout rank separation [texera]
officialasishkumar opened a new pull request, #5176:
URL: https://github.com/apache/texera/pull/5176
### What changes were proposed in this PR?
The agent service and frontend both use dagre for workflow auto-layout, but the agent service used `ranksep: 100` while the frontend uses `rankSep: 80`. That made agent-generated layouts wider than layouts produced by the frontend auto-layout button.
This PR updates the agent-service layout config to `ranksep: 80` and adds a regression test that pins the produced two-node spacing to the frontend-equivalent value.
### Any related issues, documentation, discussions?
Closes #4577.
### How was this PR tested?
Installed agent-service dependencies from `bun.lock` in the worktree, then ran:
```
npm_config_cache=/tmp/texera-npm-cache npx --yes bun@1.3.3 test src/agent/util/auto-layout.test.ts
```
Result: 7 passed.
```
npm_config_cache=/tmp/texera-npm-cache npx --yes bun@1.3.3 run typecheck
```
Result: passed.
```
npm_config_cache=/tmp/texera-npm-cache npx --yes bun@1.3.3 run format:check
```
Result: passed.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(agent-service): align auto-layout rank separation [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #5176:
URL: https://github.com/apache/texera/pull/5176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(agent-service): align auto-layout rank separation [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5176:
URL: https://github.com/apache/texera/pull/5176#issuecomment-4527926970
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5176?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 43.65%. Comparing base ([`e7e5d4e`](https://app.codecov.io/gh/apache/texera/commit/e7e5d4ee74cb7bf891218518c0c287cf3e9abdb4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c3bf588`](https://app.codecov.io/gh/apache/texera/commit/c3bf588f5adff727fa5b5c067c8c62f379c839b2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5176 +/- ##
=========================================
Coverage 43.65% 43.65%
Complexity 2219 2219
=========================================
Files 1049 1049
Lines 40572 40572
Branches 4324 4324
=========================================
Hits 17713 17713
Misses 21767 21767
Partials 1092 1092
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5176/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5176/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.53% <ø> (ø)` | | Carriedforward from [e7e5d4e](https://app.codecov.io/gh/apache/texera/commit/e7e5d4ee74cb7bf891218518c0c287cf3e9abdb4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5176/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.76% <100.00%> (ø)` | | |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5176/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.04% <ø> (ø)` | | Carriedforward from [e7e5d4e](https://app.codecov.io/gh/apache/texera/commit/e7e5d4ee74cb7bf891218518c0c287cf3e9abdb4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5176/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [e7e5d4e](https://app.codecov.io/gh/apache/texera/commit/e7e5d4ee74cb7bf891218518c0c287cf3e9abdb4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5176/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [e7e5d4e](https://app.codecov.io/gh/apache/texera/commit/e7e5d4ee74cb7bf891218518c0c287cf3e9abdb4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5176/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.18% <ø> (ø)` | | Carriedforward from [e7e5d4e](https://app.codecov.io/gh/apache/texera/commit/e7e5d4ee74cb7bf891218518c0c287cf3e9abdb4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5176/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `35.15% <ø> (ø)` | | Carriedforward from [e7e5d4e](https://app.codecov.io/gh/apache/texera/commit/e7e5d4ee74cb7bf891218518c0c287cf3e9abdb4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5176/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.50% <ø> (ø)` | | Carriedforward from [e7e5d4e](https://app.codecov.io/gh/apache/texera/commit/e7e5d4ee74cb7bf891218518c0c287cf3e9abdb4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5176/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.81% <ø> (ø)` | | Carriedforward from [e7e5d4e](https://app.codecov.io/gh/apache/texera/commit/e7e5d4ee74cb7bf891218518c0c287cf3e9abdb4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/5176?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org