You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by rschmitt <gi...@git.apache.org> on 2018/11/30 23:48:35 UTC

[GitHub] httpcomponents-core pull request #98: SSLIOSession: Add `connectTimeout` con...

GitHub user rschmitt opened a pull request:

    https://github.com/apache/httpcomponents-core/pull/98

    SSLIOSession: Add `connectTimeout` constructor param

    This change adds low-level support for TLS handshake timeouts in the
    class that actually performs the handshake. The contractual
    `socketTimeout`, if set, will only be applied to the underlying
    IOSession after the handshake is complete.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rschmitt/httpcomponents-core master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/httpcomponents-core/pull/98.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #98
    
----
commit 07d15747816f96570b6ba12324f0ede961e07c74
Author: Ryan Schmitt <rs...@...>
Date:   2018-11-30T23:44:20Z

    SSLIOSession: Add `connectTimeout` constructor param
    
    This change adds low-level support for TLS handshake timeouts in the
    class that actually performs the handshake. The contractual
    `socketTimeout`, if set, will only be applied to the underlying
    IOSession after the handshake is complete.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcomponents-core pull request #98: SSLIOSession: Add `connectTimeout` con...

Posted by rschmitt <gi...@git.apache.org>.
Github user rschmitt commented on a diff in the pull request:

    https://github.com/apache/httpcomponents-core/pull/98#discussion_r238071831
  
    --- Diff: httpcore5/src/main/java/org/apache/hc/core5/reactor/InternalDataChannel.java ---
    @@ -243,7 +243,8 @@ public void execute(final SSLIOSession sslSession) {
                             }
                         }
     
    -                }))) {
    +                },
    +                null))) {
    --- End diff --
    
    The `null` argument here is temporary. Wiring this value up all the way from `InternalHttpAsyncExecRuntime` is going to require tons of additional changes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcomponents-core pull request #98: SSLIOSession: Add `connectTimeout` con...

Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on a diff in the pull request:

    https://github.com/apache/httpcomponents-core/pull/98#discussion_r238059606
  
    --- Diff: httpcore5/src/main/java/org/apache/hc/core5/reactor/InternalDataChannel.java ---
    @@ -243,7 +243,8 @@ public void execute(final SSLIOSession sslSession) {
                             }
                         }
     
    -                }))) {
    +                },
    +                null))) {
    --- End diff --
    
    @rschmitt Do we really need an extra constructor parameter if it is always set to `null`? Otherwise looks good.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcomponents-core pull request #98: SSLIOSession: Add `connectTimeout` con...

Posted by rschmitt <gi...@git.apache.org>.
Github user rschmitt closed the pull request at:

    https://github.com/apache/httpcomponents-core/pull/98


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org