You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/02/18 00:35:56 UTC

[GitHub] [zookeeper] smikes commented on a change in pull request #1602: ZOOKEEPER-4210: Preserve return code from nonblocking send

smikes commented on a change in pull request #1602:
URL: https://github.com/apache/zookeeper/pull/1602#discussion_r578041352



##########
File path: zookeeper-client/zookeeper-client-c/src/zookeeper.c
##########
@@ -3730,8 +3745,9 @@ int zoo_awget(zhandle_t *zh, const char *path,
 
     LOG_DEBUG(LOGCALLBACK(zh), "Sending request xid=%#x for path [%s] to %s",h.xid,path,
             zoo_get_current_server(zh));
+
     /* make a best (non-blocking) effort to send the requests asap */
-    adaptor_send_queue(zh, 0);
+    return nonblocking_send(zh, rc);
     return (rc < 0)?ZMARSHALLINGERROR:ZOK;

Review comment:
       Fixed, see new commits.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org