You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Yifan Cai (Jira)" <ji...@apache.org> on 2021/09/23 20:10:00 UTC

[jira] [Commented] (CASSANDRASC-29) Avoid having sidecar's health response code depend on Cassandra's health information

    [ https://issues.apache.org/jira/browse/CASSANDRASC-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419442#comment-17419442 ] 

Yifan Cai commented on CASSANDRASC-29:
--------------------------------------

Patch looks good to me. +1 

With the patch, it is clear which service (i.e. Cassandra or Sidecar) is not available. 

> Avoid having sidecar's health response code depend on Cassandra's health information
> ------------------------------------------------------------------------------------
>
>                 Key: CASSANDRASC-29
>                 URL: https://issues.apache.org/jira/browse/CASSANDRASC-29
>             Project: Sidecar for Apache Cassandra
>          Issue Type: Improvement
>          Components: Rest API
>            Reporter: Saranya Krishnakumar
>            Assignee: Saranya Krishnakumar
>            Priority: Normal
>
> Currently sidecar's health endpoint throws 503 status code if cassandra instance is not up. This should not be the case, sidecar should return 200 if sidecar is healthy and running and should give a detailed error message saying connected cassandra instance is not up
>  
> https://github.com/apache/cassandra-sidecar/pull/21



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org