You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/06/04 08:55:33 UTC
[GitHub] [incubator-tubemq] duli559 opened a new pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink
duli559 opened a new pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128
1. Add module of 'tubemq-connectors' for project, it will contains all types of connector for TubeMQ, like Flink, Spark, etc.
2. Support TubeMQ connector of source for Apache Flink.
Jira link with: https://issues.apache.org/jira/browse/TUBEMQ-197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] guangxuCheng commented on a change in pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink
Posted by GitBox <gi...@apache.org>.
guangxuCheng commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435182723
##########
File path: pom.xml
##########
@@ -68,6 +68,7 @@
<module>tubemq-client</module>
<module>tubemq-server</module>
<module>tubemq-example</module>
+ <module>tubemq-connectors</module>
Review comment:
Remove extra spaces
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang commented on a change in pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435103721
##########
File path: tubemq-server/src/test/resource/data/00000000000000000000.tube
##########
@@ -0,0 +1 @@
+abcabc
Review comment:
Does the test data need to be combined?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] aloyszhang commented on pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#issuecomment-639217832
@duli559 Thanks for you contribution, LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] duli559 commented on a change in pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink
Posted by GitBox <gi...@apache.org>.
duli559 commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435194981
##########
File path: tubemq-connectors/tubemq-connector-flink/src/main/java/org/apache/flink/connectors/tube/Tube.java
##########
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.tube;
Review comment:
yes, it's right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] duli559 commented on a change in pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink
Posted by GitBox <gi...@apache.org>.
duli559 commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435201896
##########
File path: tubemq-connectors/tubemq-connector-flink/src/main/java/org/apache/flink/connectors/tube/TubeTableSource.java
##########
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.tube;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.TreeSet;
+
+import javax.annotation.Nullable;
+
+import org.apache.flink.api.common.serialization.DeserializationSchema;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.functions.source.SourceFunction;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.Types;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.sources.DefinedFieldMapping;
+import org.apache.flink.table.sources.DefinedProctimeAttribute;
+import org.apache.flink.table.sources.DefinedRowtimeAttributes;
+import org.apache.flink.table.sources.RowtimeAttributeDescriptor;
+import org.apache.flink.table.sources.StreamTableSource;
+import org.apache.flink.types.Row;
+
+/**
+ * Hippo {@link StreamTableSource}.
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] aloyszhang merged pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink
Posted by GitBox <gi...@apache.org>.
aloyszhang merged pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] duli559 commented on a change in pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink
Posted by GitBox <gi...@apache.org>.
duli559 commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435201803
##########
File path: pom.xml
##########
@@ -68,6 +68,7 @@
<module>tubemq-client</module>
<module>tubemq-server</module>
<module>tubemq-example</module>
+ <module>tubemq-connectors</module>
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] aloyszhang commented on a change in pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435190820
##########
File path: tubemq-connectors/tubemq-connector-flink/src/main/java/org/apache/flink/connectors/tube/TubeTableSource.java
##########
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.tube;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.TreeSet;
+
+import javax.annotation.Nullable;
+
+import org.apache.flink.api.common.serialization.DeserializationSchema;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.functions.source.SourceFunction;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.Types;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.sources.DefinedFieldMapping;
+import org.apache.flink.table.sources.DefinedProctimeAttribute;
+import org.apache.flink.table.sources.DefinedRowtimeAttributes;
+import org.apache.flink.table.sources.RowtimeAttributeDescriptor;
+import org.apache.flink.table.sources.StreamTableSource;
+import org.apache.flink.types.Row;
+
+/**
+ * Hippo {@link StreamTableSource}.
Review comment:
All `Hippo` should be replaced with TubeMQ
##########
File path: tubemq-connectors/tubemq-connector-flink/src/main/java/org/apache/flink/connectors/tube/Tube.java
##########
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.tube;
Review comment:
Shall we use TubeMQ instead of Tube in this module? I think TubeMQ is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] duli559 commented on pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink
Posted by GitBox <gi...@apache.org>.
duli559 commented on pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#issuecomment-638714380
@gosonzhang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] duli559 commented on a change in pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink
Posted by GitBox <gi...@apache.org>.
duli559 commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435111357
##########
File path: tubemq-server/src/test/resource/data/00000000000000000000.tube
##########
@@ -0,0 +1 @@
+abcabc
Review comment:
sorry, it's a wrong file, i will delete it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] duli559 commented on a change in pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink
Posted by GitBox <gi...@apache.org>.
duli559 commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435111357
##########
File path: tubemq-server/src/test/resource/data/00000000000000000000.tube
##########
@@ -0,0 +1 @@
+abcabc
Review comment:
Sorry, it's a wrong file, i will delete it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org