[GitHub] [druid] suneet-s commented on a change in pull request #10900: Add query granularity to compaction task

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #10900:
URL: https://github.com/apache/druid/pull/10900#discussion_r585699302



##########
File path: server/src/main/java/org/apache/druid/client/indexing/ClientCompactionTaskGranularitySpec.java
##########
@@ -22,26 +22,22 @@
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import org.apache.druid.java.util.common.granularity.Granularity;
-import org.apache.druid.segment.indexing.granularity.BaseGranularitySpec;
 
 import java.util.Objects;
 
-public class ClientCompactionTaskQueryGranularitySpec
+public class ClientCompactionTaskGranularitySpec

Review comment:
       Can you add a javadoc for this please. Why is this needed? Why we haven't chosen to use the GranularitySpec class that already exists?
   
   I'm ok if you do this in a follow up change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org