[PATCH] - Remove redundant code in Mapper.java

[Arvind Srinivasan <Ar...@Sun.COM>]

Attached is a simple patch (for TC 6.0's trunk) that removes a couple of 
lines of redundant code in org.apache.tomcat.util.http.mapper.Mapper

Arvind

Re: [PATCH] - Remove redundant code in Mapper.java

[Sven Köhler <sk...@upb.de>]

>> Attached is a simple patch (for TC 6.0's trunk) that removes a couple
>> of lines of redundant code in org.apache.tomcat.util.http.mapper.Mapper
> 
> I am not certain they're that redundant. I would leave them in just to
> be safe given that the cost of these calls is very low.

They are not redundant.

Arvind, take a look at the class org.apache.tomcat.util.buf.MessageBytes:
setString(String) does influence the members byteC or charC.

The MessageBytes-class can store 3 different values at once: byte[],
char[], String. These 3 values are not automatically synchronized.
Actually byteC can contain "foo", charC can contain "bar" and strValue
can contain "bla" at the same time.

Re: [PATCH] - Remove redundant code in Mapper.java

[Remy Maucherat <re...@apache.org>]

Arvind Srinivasan wrote:
> Attached is a simple patch (for TC 6.0's trunk) that removes a couple of 
> lines of redundant code in org.apache.tomcat.util.http.mapper.Mapper

I am not certain they're that redundant. I would leave them in just to 
be safe given that the cost of these calls is very low.

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org