[GitHub] [hive] pkumarsinha commented on a change in pull request #2655: HIVE-25538. CommitTxn replay failing during incremental run.

[GitBox <gi...@apache.org>]

pkumarsinha commented on a change in pull request #2655:
URL: https://github.com/apache/hive/pull/2655#discussion_r716418809



##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosIncrementalLoadAcidTables.java
##########
@@ -243,6 +248,53 @@ public void testReplCM() throws Throwable {
             Lists.newArrayList(result, result));
   }
 
+  @Test
+  public void testReplCommitTransactionOnSourceDelete() throws Throwable {
+    String tableName = "testReplCommitTransactionOnSourceDelete";
+    String[] result = new String[] { "5" };
+
+    // Do a bootstrap dump.
+    WarehouseInstance.Tuple bootStrapDump = primary.dump(primaryDbName);
+    replica.load(replicatedDbName, primaryDbName).run("REPL STATUS " + replicatedDbName)
+        .verifyResult(bootStrapDump.lastReplicationId);
+
+    // Add some data to the table & do a incremental dump.
+    ReplicationTestUtils.insertRecords(primary, primaryDbName, primaryDbNameExtra, tableName, null, false,
+        ReplicationTestUtils.OperationType.REPL_TEST_ACID_INSERT);
+    WarehouseInstance.Tuple incrementalDump = primary.dump(primaryDbName);

Review comment:
       Can you please add the tables with following property:
   - ORC Format (I think covered)
   - bucketed 
   - text input folder
   All these tables should have a drop table use case like you are targeting now?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org