You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "freemandealer (via GitHub)" <gi...@apache.org> on 2025/04/25 01:47:34 UTC
[PR] [fix](cloud) FDCache nullptr when doris exit [doris]
freemandealer opened a new pull request, #50397:
URL: https://github.com/apache/doris/pull/50397
FDCache release before CacheManager will cause NPE
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [x] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) FDCache nullptr when doris exit [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50397:
URL: https://github.com/apache/doris/pull/50397#issuecomment-2829197940
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) FDCache nullptr when doris exit [doris]
Posted by "freemandealer (via GitHub)" <gi...@apache.org>.
freemandealer commented on PR #50397:
URL: https://github.com/apache/doris/pull/50397#issuecomment-2829196333
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) FDCache nullptr when doris exit [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50397:
URL: https://github.com/apache/doris/pull/50397#issuecomment-2829251168
<details>
<summary>TPC-DS: <b>Total hot run time: 193364 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 95477d9ab510c84af7f78e9870286e07e8349834, data reload: false
query1 1389 1101 1058 1058
query2 6423 1818 1772 1772
query3 11041 4545 4572 4545
query4 57030 24897 23577 23577
query5 5201 474 438 438
query6 402 187 185 185
query7 5217 511 282 282
query8 334 257 240 240
query9 7143 2558 2600 2558
query10 435 324 269 269
query11 15293 15005 14889 14889
query12 156 108 108 108
query13 1261 520 398 398
query14 9993 6359 6394 6359
query15 200 189 190 189
query16 6989 665 551 551
query17 1070 727 575 575
query18 1543 394 324 324
query19 203 192 165 165
query20 128 124 131 124
query21 205 134 109 109
query22 4561 4532 4366 4366
query23 34155 33444 33452 33444
query24 6853 2436 2427 2427
query25 466 459 406 406
query26 656 277 152 152
query27 2220 504 336 336
query28 2939 2138 2126 2126
query29 624 595 474 474
query30 274 225 196 196
query31 840 841 790 790
query32 77 67 61 61
query33 454 363 318 318
query34 781 866 508 508
query35 813 853 759 759
query36 953 993 912 912
query37 125 109 83 83
query38 4229 4237 4223 4223
query39 1496 1464 1454 1454
query40 224 121 115 115
query41 64 57 64 57
query42 126 118 109 109
query43 504 514 476 476
query44 1366 834 844 834
query45 179 181 171 171
query46 874 1043 646 646
query47 1811 1865 1849 1849
query48 396 422 301 301
query49 710 500 437 437
query50 680 715 396 396
query51 4252 4234 4195 4195
query52 107 107 92 92
query53 219 253 180 180
query54 598 577 521 521
query55 82 77 83 77
query56 296 313 288 288
query57 1184 1218 1131 1131
query58 258 253 245 245
query59 2763 2848 2699 2699
query60 329 319 307 307
query61 133 125 123 123
query62 739 742 699 699
query63 226 194 180 180
query64 1454 999 724 724
query65 4276 4210 4193 4193
query66 712 392 299 299
query67 15744 15416 15321 15321
query68 7712 818 507 507
query69 544 299 262 262
query70 1172 1110 1128 1110
query71 498 301 299 299
query72 5794 4821 4963 4821
query73 1203 706 348 348
query74 9044 9051 8990 8990
query75 3744 3218 2724 2724
query76 4287 1193 759 759
query77 600 356 284 284
query78 10066 10058 9347 9347
query79 2139 858 553 553
query80 573 497 444 444
query81 483 251 217 217
query82 453 123 98 98
query83 255 249 231 231
query84 286 102 88 88
query85 791 416 309 309
query86 414 305 286 286
query87 4455 4501 4325 4325
query88 3592 2255 2226 2226
query89 399 317 287 287
query90 1818 218 221 218
query91 141 137 110 110
query92 73 65 58 58
query93 1852 949 577 577
query94 672 410 263 263
query95 375 285 285 285
query96 496 564 280 280
query97 3152 3278 3132 3132
query98 227 208 195 195
query99 1446 1414 1316 1316
Total cold run time: 303234 ms
Total hot run time: 193364 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) FDCache nullptr when doris exit [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50397:
URL: https://github.com/apache/doris/pull/50397#issuecomment-2829196244
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) FDCache nullptr when doris exit [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50397:
URL: https://github.com/apache/doris/pull/50397#issuecomment-2829359827
# BE Regression P0 && UT Coverage Report
Increment line coverage `100.00% (1/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50397_95477d9ab510c84af7f78e9870286e07e8349834_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50397_95477d9ab510c84af7f78e9870286e07e8349834_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.26% (14733/26661) |
| Line Coverage | 44.71% (132796/297034) |
| Region Coverage | 41.88% (76609/182915) |
| Branch Coverage | 35.95% (37087/103156) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) FDCache nullptr when doris exit [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50397:
URL: https://github.com/apache/doris/pull/50397#issuecomment-2829255680
<details>
<summary>ClickBench: <b>Total hot run time: 29.13 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 95477d9ab510c84af7f78e9870286e07e8349834, data reload: false
query1 0.03 0.03 0.03
query2 0.12 0.11 0.11
query3 0.25 0.20 0.19
query4 1.59 0.19 0.20
query5 0.59 0.57 0.58
query6 1.17 0.71 0.72
query7 0.02 0.02 0.02
query8 0.04 0.04 0.03
query9 0.58 0.52 0.51
query10 0.57 0.57 0.56
query11 0.15 0.11 0.11
query12 0.15 0.11 0.11
query13 0.61 0.58 0.60
query14 1.14 1.18 1.16
query15 0.88 0.85 0.86
query16 0.37 0.41 0.38
query17 1.03 1.05 1.04
query18 0.22 0.20 0.20
query19 1.85 1.74 1.79
query20 0.01 0.01 0.01
query21 15.42 0.89 0.55
query22 0.76 1.19 0.75
query23 14.80 1.42 0.62
query24 7.69 1.62 0.35
query25 0.30 0.08 0.17
query26 0.56 0.17 0.15
query27 0.05 0.05 0.05
query28 9.30 0.87 0.44
query29 12.52 3.95 3.37
query30 0.26 0.09 0.07
query31 2.81 0.59 0.39
query32 3.21 0.53 0.46
query33 2.97 3.05 3.02
query34 15.73 5.05 4.46
query35 4.48 4.54 4.48
query36 0.67 0.50 0.48
query37 0.09 0.07 0.06
query38 0.06 0.04 0.04
query39 0.03 0.02 0.02
query40 0.18 0.13 0.12
query41 0.08 0.03 0.02
query42 0.04 0.02 0.03
query43 0.03 0.03 0.03
Total cold run time: 103.41 s
Total hot run time: 29.13 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) FDCache nullptr when doris exit [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50397:
URL: https://github.com/apache/doris/pull/50397#issuecomment-2829239798
<details>
<summary>TPC-H: <b>Total hot run time: 33818 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 95477d9ab510c84af7f78e9870286e07e8349834, data reload: false
------ Round 1 ----------------------------------
q1 26231 5053 5042 5042
q2 2054 270 179 179
q3 10408 1267 683 683
q4 10354 1007 518 518
q5 7761 2562 2370 2370
q6 185 165 131 131
q7 913 752 621 621
q8 9310 1271 1080 1080
q9 6860 5089 5074 5074
q10 6863 2313 1883 1883
q11 482 276 266 266
q12 351 344 212 212
q13 17804 3679 3057 3057
q14 236 224 211 211
q15 535 484 478 478
q16 448 440 397 397
q17 573 860 347 347
q18 7459 7153 7164 7153
q19 1529 923 544 544
q20 336 317 217 217
q21 4192 2643 2413 2413
q22 1039 990 942 942
Total cold run time: 115923 ms
Total hot run time: 33818 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5119 5085 5079 5079
q2 227 331 228 228
q3 2143 2607 2302 2302
q4 1452 1786 1395 1395
q5 4435 4417 4374 4374
q6 218 163 127 127
q7 1985 1904 1721 1721
q8 2577 2556 2488 2488
q9 7248 7240 6951 6951
q10 3034 3206 2723 2723
q11 569 498 482 482
q12 697 784 609 609
q13 3505 3897 3286 3286
q14 270 291 263 263
q15 534 489 482 482
q16 465 523 481 481
q17 1135 1548 1350 1350
q18 7694 7608 7421 7421
q19 802 792 821 792
q20 2010 2066 1856 1856
q21 5200 4947 4715 4715
q22 1079 1036 1018 1018
Total cold run time: 52398 ms
Total hot run time: 50143 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) FDCache nullptr when doris exit [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50397:
URL: https://github.com/apache/doris/pull/50397#issuecomment-2829288102
# BE UT Coverage Report
Increment line coverage `100.00% (1/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/95477d9ab510c84af7f78e9870286e07e8349834_95477d9ab510c84af7f78e9870286e07e8349834/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/95477d9ab510c84af7f78e9870286e07e8349834_95477d9ab510c84af7f78e9870286e07e8349834/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.75% (14595/27151) |
| Line Coverage | 42.57% (126644/297523) |
| Region Coverage | 41.38% (64765/156503) |
| Branch Coverage | 35.93% (32558/90608) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) FDCache nullptr when doris exit [doris]
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on code in PR #50397:
URL: https://github.com/apache/doris/pull/50397#discussion_r2059521633
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -803,6 +802,7 @@ void ExecEnv::destroy() {
// cache_manager must be destoried after all cache.
// https://github.com/apache/doris/issues/24082#issuecomment-1712544039
SAFE_DELETE(_cache_manager);
+ _file_cache_open_fd_cache.reset(nullptr);
Review Comment:
please also add a comment here like `_cache_manager`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) FDCache nullptr when doris exit [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50397:
URL: https://github.com/apache/doris/pull/50397#issuecomment-2829197825
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) FDCache nullptr when doris exit [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #50397:
URL: https://github.com/apache/doris/pull/50397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org