[jira] [Commented] (ZOOKEEPER-2921) fsyncWarningThresholdMS is applied on each getChannel().force() - also needed on entire commit

["Patrick Hunt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211121#comment-16211121 ] 

Patrick Hunt commented on ZOOKEEPER-2921:
-----------------------------------------

Agree with the sentiment, however not the wording. Disagree with "more useful" as the fsync warning is specifically there to identify when the fsync is slow - the typical case being when ZK is colocated with other services. Having this indication makes debugging a breeze for this issue. Don't change the existing funcationality. 

That said having such a warning when request latency exceeds some threshold would also be useful. However it should not be overloaded/combined/replacing/etc... the existing fsync check.

> fsyncWarningThresholdMS is applied on each getChannel().force() - also needed on entire commit
> ----------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2921
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2921
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.5.3
>            Reporter: Jordan Zimmerman
>            Priority: Minor
>
> FileTxnLog.commit() has a warning when an individual sync takes longer than {{fsyncWarningThresholdMS}}. However, it would be more useful to warn when the entire commit operation takes longer than {{fsyncWarningThresholdMS}} as this can cause client connection failures. Currently, commit() can take longer than 2/3 of a session but still not log a warning.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)