You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zanmato1984 (via GitHub)" <gi...@apache.org> on 2025/05/16 18:41:41 UTC

[PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

zanmato1984 opened a new pull request, #46476:
URL: https://github.com/apache/arrow/pull/46476

   ### What changes are included in this PR?
   
   1. Move current Acero Developer's Guild under user doc to where under developer docs;
   2. Make it the main doc enclosing elaborating docs like Swiss table.
   
   ### Are these changes tested?
   
   No need.
   
   ### Are there any user-facing changes?
   
   None.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #46476:
URL: https://github.com/apache/arrow/pull/46476#discussion_r2098631988


##########
docs/source/cpp/acero.rst:
##########


Review Comment:
   Thanks. It looks like the ToC from the developer guide gets inlined into the user guide ToC which I don't think we want/need. The sidebar ToC looks right (there are four items) though. I can take a crack at it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46476:
URL: https://github.com/apache/arrow/pull/46476#discussion_r2098617281


##########
docs/source/cpp/acero.rst:
##########


Review Comment:
   Hi @amoeba , please checkout the latest preview: http://crossbow.voltrondata.com/pr_docs/46476/cpp/acero.html
   
   I added the link to the Acero dev doc as an entry of TOC of Acero user doc, so the link shows up in the TOC as well as the navigation on the left. Does this make sense to you? Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #46476:
URL: https://github.com/apache/arrow/pull/46476#discussion_r2100445776


##########
docs/source/cpp/acero.rst:
##########
@@ -27,6 +27,12 @@ Acero: A C++ streaming execution engine
 
     Acero is experimental and a stable API is not yet guaranteed.
 
+.. note::
+
+    If you are interested in contributing to Acero or learning about its
+    internals, please see the `Acero Developer's Guide
+    <../developers/cpp/acero>`_.

Review Comment:
   Yep, looks right. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46476:
URL: https://github.com/apache/arrow/pull/46476#issuecomment-2887560111

   There we go.
   
   User doc: [before](https://arrow.apache.org/docs/cpp/streaming_execution.html), [after](http://crossbow.voltrondata.com/pr_docs/46476/cpp/acero.html) (preview).
   
   Dev doc: [before](https://arrow.apache.org/docs/developers/cpp/index.html) (no Acero yet), [after](http://crossbow.voltrondata.com/pr_docs/46476/developers/cpp/acero.html) (preview).
   
   @raulcd @amoeba @pitrou PTAL. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #46476:
URL: https://github.com/apache/arrow/pull/46476#discussion_r2098971377


##########
docs/source/cpp/acero.rst:
##########
@@ -27,6 +27,12 @@ Acero: A C++ streaming execution engine
 
     Acero is experimental and a stable API is not yet guaranteed.
 
+.. note::
+
+    If you are interested in contributing to Acero or learning about its
+    internals, please see the `Acero Developer's Guide
+    <../developers/cpp/acero>`_.

Review Comment:
   Can we use a `:doc:` directive to link directly to the doc? I'll see if I can get a working local docs build to test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 merged PR #46476:
URL: https://github.com/apache/arrow/pull/46476


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46476:
URL: https://github.com/apache/arrow/pull/46476#issuecomment-2899487414

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8590bc621a868212bc8a184d0a1022f2ba87fd56.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/42671986829) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #46476:
URL: https://github.com/apache/arrow/pull/46476#discussion_r2098351152


##########
docs/source/cpp/acero.rst:
##########


Review Comment:
   I think it would be good add a link to the Acero developer guide from the Acero user guide. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46476:
URL: https://github.com/apache/arrow/pull/46476#discussion_r2098985297


##########
docs/source/cpp/acero.rst:
##########
@@ -27,6 +27,12 @@ Acero: A C++ streaming execution engine
 
     Acero is experimental and a stable API is not yet guaranteed.
 
+.. note::
+
+    If you are interested in contributing to Acero or learning about its
+    internals, please see the `Acero Developer's Guide
+    <../developers/cpp/acero>`_.

Review Comment:
   Good point, and it works in my local. Updated in [`a6e27d0` (#46476)](https://github.com/apache/arrow/pull/46476/commits/a6e27d0cd11465ecfaece072987f966d19dacae3). Thank you for the tip!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46476:
URL: https://github.com/apache/arrow/pull/46476#issuecomment-2895999031

   @github-actions crossbow submit preview-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46476:
URL: https://github.com/apache/arrow/pull/46476#discussion_r2093538743


##########
docs/source/developers/cpp/acero.rst:
##########


Review Comment:
   This file is moved from "docs/source/cpp/acero/developer_guide.rst" with two small tweaks:
   1. Changing the title from "Developer’s Guide" to "Developing Acero" (which is more aligned with the naming of other docs at the same level).
   2. Adding the "Others" section at the bottom as a TOC to enclose sub-docs which are too elaborate to be inlined (currently only swiss_table.rst).
   
   Please note the original "acero.rst" was moved to "acero/swiss_table.rst" (I was thinking about inlining it however found it too long), but git doesn't recognize this pattern and shows many diffs. The actual changes are just the two places mentioned above.



##########
docs/source/developers/cpp/acero/swiss_table.rst:
##########


Review Comment:
   As mentioned in other comment, this is renamed from "developers/cpp/acero.rst".



##########
docs/source/cpp/acero.rst:
##########


Review Comment:
   Note this is renamed from "streaming_execution.rst" to "acero.rst" which is more explicit (and shorter). Because "Acero" has become a much more well-known name I assume.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46476:
URL: https://github.com/apache/arrow/pull/46476#discussion_r2098648801


##########
docs/source/cpp/acero.rst:
##########


Review Comment:
   Perhaps the side bar and the TOC in the article body have different rational for displaying hierarchies: the former is doc-based and the later is section-based I guess?
   
   How about we add another `toctree` with `maxdepth 1` only for the Acero dev doc? (RST doesn't support different depth for an individual entry.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46476:
URL: https://github.com/apache/arrow/pull/46476#issuecomment-2898335148

   Thank you @amoeba @raulcd for reviewing. I'm merging this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46476:
URL: https://github.com/apache/arrow/pull/46476#issuecomment-2895286351

   Revision: cf454394f4b91e09fffd1d131f8918f46a994764
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-e9a41fd8cd](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e9a41fd8cd)
   
   |Task|Status|
   |----|------|
   |preview-docs|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-e9a41fd8cd-github-preview-docs)](https://github.com/ursacomputing/crossbow/actions/runs/15144063646/job/42575280079)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #46476:
URL: https://github.com/apache/arrow/pull/46476#discussion_r2098652572


##########
docs/source/cpp/acero.rst:
##########


Review Comment:
   What do you think about db0d855c4f7043025b624f53516277dd321152aa? I thought a Note box at the top of the user guide would be slightly more visible for people. I'm not 100% it renders correctly since the docs aren't fully building so we should check with crossbow before merging.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46476:
URL: https://github.com/apache/arrow/pull/46476#discussion_r2098939723


##########
docs/source/cpp/acero.rst:
##########
@@ -27,6 +27,12 @@ Acero: A C++ streaming execution engine
 
     Acero is experimental and a stable API is not yet guaranteed.
 
+.. note::
+
+    If you are interested in contributing to Acero or learning about its
+    internals, please see the `Acero Developer's Guide
+    <../developers/cpp/acero>`_.

Review Comment:
   Like this [`d6d32a8` (#46476)](https://github.com/apache/arrow/pull/46476/commits/d6d32a878ef2b3deedc8d309465ca5293c161c51) ? @amoeba 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46476:
URL: https://github.com/apache/arrow/pull/46476#issuecomment-2895786247

   @github-actions crossbow submit preview-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46476:
URL: https://github.com/apache/arrow/pull/46476#discussion_r2099031174


##########
docs/source/cpp/acero.rst:
##########
@@ -27,6 +27,12 @@ Acero: A C++ streaming execution engine
 
     Acero is experimental and a stable API is not yet guaranteed.
 
+.. note::
+
+    If you are interested in contributing to Acero or learning about its
+    internals, please see the `Acero Developer's Guide
+    <../developers/cpp/acero>`_.

Review Comment:
   It works as expected in the preview: http://crossbow.voltrondata.com/pr_docs/46476/cpp/acero.html
   
   @amoeba PTAL. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #46476:
URL: https://github.com/apache/arrow/pull/46476#issuecomment-2898435461

   Thanks for this @zanmato1984.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46476:
URL: https://github.com/apache/arrow/pull/46476#issuecomment-2895279958

   @github-actions crossbow submit preview-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46476:
URL: https://github.com/apache/arrow/pull/46476#issuecomment-2887438764

   :warning: GitHub issue #46475 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46476:
URL: https://github.com/apache/arrow/pull/46476#issuecomment-2887469096

   Revision: 3685f4d56fcabd7e93be5f1ce1841f9c3d10a19c
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-9fea3f3368](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9fea3f3368)
   
   |Task|Status|
   |----|------|
   |preview-docs|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9fea3f3368-github-preview-docs)](https://github.com/ursacomputing/crossbow/actions/runs/15075478982/job/42381795583)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46476:
URL: https://github.com/apache/arrow/pull/46476#issuecomment-2896001859

   Revision: a6e27d0cd11465ecfaece072987f966d19dacae3
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-e4d7983845](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e4d7983845)
   
   |Task|Status|
   |----|------|
   |preview-docs|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-e4d7983845-github-preview-docs)](https://github.com/ursacomputing/crossbow/actions/runs/15149406757/job/42592542169)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46476:
URL: https://github.com/apache/arrow/pull/46476#discussion_r2098518741


##########
docs/source/cpp/acero.rst:
##########


Review Comment:
   Good idea. Let me do some experiments to find the best way to add it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46476:
URL: https://github.com/apache/arrow/pull/46476#issuecomment-2887465183

   @github-actions crossbow submit preview-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46476:
URL: https://github.com/apache/arrow/pull/46476#issuecomment-2895790825

   Revision: db0d855c4f7043025b624f53516277dd321152aa
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-210cc99997](https://github.com/ursacomputing/crossbow/branches/all?query=actions-210cc99997)
   
   |Task|Status|
   |----|------|
   |preview-docs|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-210cc99997-github-preview-docs)](https://github.com/ursacomputing/crossbow/actions/runs/15147513218/job/42586684212)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46476:
URL: https://github.com/apache/arrow/pull/46476#discussion_r2098843394


##########
docs/source/cpp/acero.rst:
##########


Review Comment:
   This looks good to me. Thanks. Let me trigger a crossbow build.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46475: [Documentation][C++][Compute] Consolidate Acero developer docs [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46476:
URL: https://github.com/apache/arrow/pull/46476#discussion_r2098937362


##########
docs/source/cpp/acero.rst:
##########
@@ -27,6 +27,12 @@ Acero: A C++ streaming execution engine
 
     Acero is experimental and a stable API is not yet guaranteed.
 
+.. note::
+
+    If you are interested in contributing to Acero or learning about its
+    internals, please see the `Acero Developer's Guide
+    <../developers/cpp/acero>`_.

Review Comment:
   This links to page 404. I think we need an anchor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org