Re: cvs commit: apache-2.0/src/main http_log.c

[Greg Stein <gs...@lyra.org>]

On Wed, Jul 12, 2000 at 06:40:30PM -0000, stoddard@locus.apache.org wrote:
> stoddard    00/07/12 11:40:28
> 
>   Modified:    src/main http_log.c
>   Log:
>   Fix a nasty stack corruption. ap_proc_t should be allocated out of the same
>   pool passed to ap_create_process. A little further down the road to getting
>   reliable piped logs working on Win32.

Why doesn't ap_create_process() allocate and return one? (like most other
APR functions)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Re: cvs commit: apache-2.0/src/main http_log.c

[rb...@covalent.net]

Because ap_proc_t isn't an incomplete type.  I believe at one point
create_process did allocate the space for us, but when we changed the type
to be complete, that was no longer necessary, and it made the code harder
to deal with.  This is the same way all of the other APR complete types
work.

Ryan

On Wed, 12 Jul 2000, Greg Stein wrote:

> On Wed, Jul 12, 2000 at 06:40:30PM -0000, stoddard@locus.apache.org wrote:
> > stoddard    00/07/12 11:40:28
> > 
> >   Modified:    src/main http_log.c
> >   Log:
> >   Fix a nasty stack corruption. ap_proc_t should be allocated out of the same
> >   pool passed to ap_create_process. A little further down the road to getting
> >   reliable piped logs working on Win32.
> 
> Why doesn't ap_create_process() allocate and return one? (like most other
> APR functions)
> 
> Cheers,
> -g
> 
> -- 
> Greg Stein, http://www.lyra.org/
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------