[GitHub] [zookeeper] doxsch commented on a change in pull request #1682: ZOOKEEPER-3731: Disallow HTTP TRACE method on PrometheusMetrics Server

[GitBox <gi...@apache.org>]

doxsch commented on a change in pull request #1682:
URL: https://github.com/apache/zookeeper/pull/1682#discussion_r689783512



##########
File path: zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/test/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProviderTest.java
##########
@@ -57,7 +62,7 @@ public void setup() throws Exception {
         provider = new PrometheusMetricsProvider();
         Properties configuration = new Properties();
         configuration.setProperty("httpHost", "127.0.0.1"); // local host for test
-        configuration.setProperty("httpPort", "0"); // ephemeral port
+        configuration.setProperty("httpPort", String.valueOf(METRICS_PORT));

Review comment:
       I have modified the test so that it uses an ephemeral port.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org