You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by Konstantin Gribov <gr...@gmail.com> on 2015/03/30 16:59:56 UTC
Broken build because of clirr plugin
Hi, folks.
I've broken build (by commit r1670105 for TIKA-1587).
Should I revert this commit and change it to preserve old API or add
exclude to clirr plugin configuration?
--
Best regards,
Konstantin Gribov
Re: Broken build because of clirr plugin
Posted by Konstantin Gribov <gr...@gmail.com>.
Thanks for your help in resolving this issue, Tim.
Commited in r1670125, jenkins build succeed.
--
Best regards,
Konstantin Gribov
пн, 30 марта 2015 г. в 18:56, Allison, Timothy B. <ta...@mitre.org>:
+1. Thank you, Konstantin!
>
> -----Original Message-----
> From: Konstantin Gribov [mailto:grossws@gmail.com]
> Sent: Monday, March 30, 2015 11:19 AM
> To: dev@tika.apache.org
> Subject: Re: Broken build because of clirr plugin
>
> I think, simple way would be to keep old methods (and mark them
> @Deprecated) to avoid build failure. And use new ones internally.
>
> I'll do `mvn verify` before commiting this time. Sorry for inconvenience.
>
> --
> Best regards,
> Konstantin Gribov
>
> пн, 30 марта 2015 г. в 18:09, Allison, Timothy B. <ta...@mitre.org>:
>
> > How much of an effort would it be to migrate somewhat slowly:
> >
> > Leave in but deprecate setCommandLine(String ) and String
> getCommandLine()
> >
> > Add something like: setCommandLineArr(String[] ) and String[]
> > getCommandLineArr()?
> >
> >
> >
> > -----Original Message-----
> > From: Konstantin Gribov [mailto:grossws@gmail.com]
> > Sent: Monday, March 30, 2015 11:00 AM
> > To: dev@tika.apache.org
> > Subject: Broken build because of clirr plugin
> >
> > Hi, folks.
> >
> > I've broken build (by commit r1670105 for TIKA-1587).
> > Should I revert this commit and change it to preserve old API or add
> > exclude to clirr plugin configuration?
> >
> > --
> > Best regards,
> > Konstantin Gribov
> >
>
RE: Broken build because of clirr plugin
Posted by "Allison, Timothy B." <ta...@mitre.org>.
+1. Thank you, Konstantin!
-----Original Message-----
From: Konstantin Gribov [mailto:grossws@gmail.com]
Sent: Monday, March 30, 2015 11:19 AM
To: dev@tika.apache.org
Subject: Re: Broken build because of clirr plugin
I think, simple way would be to keep old methods (and mark them
@Deprecated) to avoid build failure. And use new ones internally.
I'll do `mvn verify` before commiting this time. Sorry for inconvenience.
--
Best regards,
Konstantin Gribov
пн, 30 марта 2015 г. в 18:09, Allison, Timothy B. <ta...@mitre.org>:
> How much of an effort would it be to migrate somewhat slowly:
>
> Leave in but deprecate setCommandLine(String ) and String getCommandLine()
>
> Add something like: setCommandLineArr(String[] ) and String[]
> getCommandLineArr()?
>
>
>
> -----Original Message-----
> From: Konstantin Gribov [mailto:grossws@gmail.com]
> Sent: Monday, March 30, 2015 11:00 AM
> To: dev@tika.apache.org
> Subject: Broken build because of clirr plugin
>
> Hi, folks.
>
> I've broken build (by commit r1670105 for TIKA-1587).
> Should I revert this commit and change it to preserve old API or add
> exclude to clirr plugin configuration?
>
> --
> Best regards,
> Konstantin Gribov
>
Re: Broken build because of clirr plugin
Posted by "Mattmann, Chris A (3980)" <ch...@jpl.nasa.gov>.
No worries Konstantin thank you! Thanks Tim!
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Chief Architect
Instrument Software and Science Data Systems Section (398)
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 168-519, Mailstop: 168-527
Email: chris.a.mattmann@nasa.gov
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Associate Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
-----Original Message-----
From: Konstantin Gribov <gr...@gmail.com>
Reply-To: "dev@tika.apache.org" <de...@tika.apache.org>
Date: Monday, March 30, 2015 at 8:18 AM
To: "dev@tika.apache.org" <de...@tika.apache.org>
Subject: Re: Broken build because of clirr plugin
>I think, simple way would be to keep old methods (and mark them
>@Deprecated) to avoid build failure. And use new ones internally.
>
>I'll do `mvn verify` before commiting this time. Sorry for inconvenience.
>
>--
>Best regards,
>Konstantin Gribov
>
>пн, 30 марта 2015 г. в 18:09, Allison, Timothy B. <ta...@mitre.org>:
>
>> How much of an effort would it be to migrate somewhat slowly:
>>
>> Leave in but deprecate setCommandLine(String ) and String
>>getCommandLine()
>>
>> Add something like: setCommandLineArr(String[] ) and String[]
>> getCommandLineArr()?
>>
>>
>>
>> -----Original Message-----
>> From: Konstantin Gribov [mailto:grossws@gmail.com]
>> Sent: Monday, March 30, 2015 11:00 AM
>> To: dev@tika.apache.org
>> Subject: Broken build because of clirr plugin
>>
>> Hi, folks.
>>
>> I've broken build (by commit r1670105 for TIKA-1587).
>> Should I revert this commit and change it to preserve old API or add
>> exclude to clirr plugin configuration?
>>
>> --
>> Best regards,
>> Konstantin Gribov
>>
Re: Broken build because of clirr plugin
Posted by Konstantin Gribov <gr...@gmail.com>.
I think, simple way would be to keep old methods (and mark them
@Deprecated) to avoid build failure. And use new ones internally.
I'll do `mvn verify` before commiting this time. Sorry for inconvenience.
--
Best regards,
Konstantin Gribov
пн, 30 марта 2015 г. в 18:09, Allison, Timothy B. <ta...@mitre.org>:
> How much of an effort would it be to migrate somewhat slowly:
>
> Leave in but deprecate setCommandLine(String ) and String getCommandLine()
>
> Add something like: setCommandLineArr(String[] ) and String[]
> getCommandLineArr()?
>
>
>
> -----Original Message-----
> From: Konstantin Gribov [mailto:grossws@gmail.com]
> Sent: Monday, March 30, 2015 11:00 AM
> To: dev@tika.apache.org
> Subject: Broken build because of clirr plugin
>
> Hi, folks.
>
> I've broken build (by commit r1670105 for TIKA-1587).
> Should I revert this commit and change it to preserve old API or add
> exclude to clirr plugin configuration?
>
> --
> Best regards,
> Konstantin Gribov
>
RE: Broken build because of clirr plugin
Posted by "Allison, Timothy B." <ta...@mitre.org>.
How much of an effort would it be to migrate somewhat slowly:
Leave in but deprecate setCommandLine(String ) and String getCommandLine()
Add something like: setCommandLineArr(String[] ) and String[] getCommandLineArr()?
-----Original Message-----
From: Konstantin Gribov [mailto:grossws@gmail.com]
Sent: Monday, March 30, 2015 11:00 AM
To: dev@tika.apache.org
Subject: Broken build because of clirr plugin
Hi, folks.
I've broken build (by commit r1670105 for TIKA-1587).
Should I revert this commit and change it to preserve old API or add
exclude to clirr plugin configuration?
--
Best regards,
Konstantin Gribov