[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7386: Add domainpath to listnetwork and UI network tab

["weizhouapache (via GitHub)" <gi...@apache.org>]

weizhouapache commented on code in PR #7386:
URL: https://github.com/apache/cloudstack/pull/7386#discussion_r1192028410


##########
api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java:
##########
@@ -163,6 +163,10 @@ public class NetworkResponse extends BaseResponseWithAssociatedNetwork implement
     @Param(description = "the domain name of the network owner")
     private String domain;
 
+    @SerializedName(ApiConstants.DOMAIN_PATH)
+    @Param(description = "path of the Domain the network belongs to", since = "4.18.1")

Review Comment:
   @pierrelefevre 
   the target branch "main" is 4.19.0.0, not 4.18.1
   
   if you want it to be merged into 4.18.1.0, please rebase with 4.18 branch and change target branch to 4.18. thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org