You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brpc.apache.org by "chenBright (via GitHub)" <gi...@apache.org> on 2023/02/18 08:14:38 UTC

Re: [PR] Periodic ns quit (brpc)

chenBright commented on PR #2123:
URL: https://github.com/apache/brpc/pull/2123#issuecomment-1435518944

   @wwbmmm @serverglen 
   之前理解错了，ConsulNamingService其实不是PeriodicNamingService，不是简单的轮询，而是[长轮询](https://brpc.incubator.apache.org/zh/docs/client/basics/#consulservice-name)，每次rpc成功后，立即发起下一次长轮询。
   [Blocking Queries](https://developer.hashicorp.com/consul/api-docs/features/blocking)：
   > Many endpoints in Consul support a feature known as "blocking queries". A blocking query is used to wait for a potential change using long polling.
   
   这个pr可能需要回退一下或者重新提一个pr将ConsulNamingService改回去。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org