You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/04/16 21:10:35 UTC
[PR] GH-41238: [Release] Use UTF-8 as the default encoding to upload binary [arrow]
kou opened a new pull request, #41242:
URL: https://github.com/apache/arrow/pull/41242
### Rationale for this change
We may have non ASCII characters in the process. For example, PGP uid may include non ASCII characters.
### What changes are included in this PR?
Use `LANG=C.UTF-8` to use UTF-8 as the default encoding.
### Are these changes tested?
No.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41238: [Release] Use UTF-8 as the default encoding to upload binary [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #41242:
URL: https://github.com/apache/arrow/pull/41242#discussion_r1568254629
##########
dev/release/05-binary-upload.sh:
##########
@@ -21,8 +21,17 @@ set -e
set -u
set -o pipefail
-export LANG=C
-export LC_CTYPE=C
+export LANG=C.UTF-8
+export LC_ADDRESS=C.UTF-8
+export LC_CTYPE=C.UTF-8
+export LC_IDENTIFICATION=C.UTF-8
+export LC_MEASUREMENT=C.UTF-8
+export LC_MONETARY=C.UTF-8
+export LC_NAME=C.UTF-8
+export LC_NUMERIC=C.UTF-8
+export LC_PAPER=C.UTF-8
+export LC_TELEPHONE=C.UTF-8
+export LC_TIME=C.UTF-8
Review Comment:
Ah, I misunderstood `LC_ALL`. It can be overwritten by other `LC_*` like `LANG`.
I'll simplify the code. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41238: [Release] Use UTF-8 as the default encoding to upload binary [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41242:
URL: https://github.com/apache/arrow/pull/41242#issuecomment-2059928750
:warning: GitHub issue #41238 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41238: [Release] Use UTF-8 as the default encoding to upload binary [arrow]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on code in PR #41242:
URL: https://github.com/apache/arrow/pull/41242#discussion_r1568193768
##########
dev/release/05-binary-upload.sh:
##########
@@ -21,8 +21,17 @@ set -e
set -u
set -o pipefail
-export LANG=C
-export LC_CTYPE=C
+export LANG=C.UTF-8
+export LC_ADDRESS=C.UTF-8
+export LC_CTYPE=C.UTF-8
+export LC_IDENTIFICATION=C.UTF-8
+export LC_MEASUREMENT=C.UTF-8
+export LC_MONETARY=C.UTF-8
+export LC_NAME=C.UTF-8
+export LC_NUMERIC=C.UTF-8
+export LC_PAPER=C.UTF-8
+export LC_TELEPHONE=C.UTF-8
+export LC_TIME=C.UTF-8
Review Comment:
You could set `LC_ALL=C.UTF-8`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41238: [Release] Use UTF-8 as the default encoding to upload binary [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #41242:
URL: https://github.com/apache/arrow/pull/41242#discussion_r1568254629
##########
dev/release/05-binary-upload.sh:
##########
@@ -21,8 +21,17 @@ set -e
set -u
set -o pipefail
-export LANG=C
-export LC_CTYPE=C
+export LANG=C.UTF-8
+export LC_ADDRESS=C.UTF-8
+export LC_CTYPE=C.UTF-8
+export LC_IDENTIFICATION=C.UTF-8
+export LC_MEASUREMENT=C.UTF-8
+export LC_MONETARY=C.UTF-8
+export LC_NAME=C.UTF-8
+export LC_NUMERIC=C.UTF-8
+export LC_PAPER=C.UTF-8
+export LC_TELEPHONE=C.UTF-8
+export LC_TIME=C.UTF-8
Review Comment:
Ah, I misunderstood `LC_ALL`. I thought it can be overwritten by other `LC_*` like `LANG`.
I'll simplify the code. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41238: [Release] Use UTF-8 as the default encoding to upload binary [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #41242:
URL: https://github.com/apache/arrow/pull/41242#discussion_r1568260748
##########
dev/release/05-binary-upload.sh:
##########
@@ -21,8 +21,17 @@ set -e
set -u
set -o pipefail
-export LANG=C
-export LC_CTYPE=C
+export LANG=C.UTF-8
+export LC_ADDRESS=C.UTF-8
+export LC_CTYPE=C.UTF-8
+export LC_IDENTIFICATION=C.UTF-8
+export LC_MEASUREMENT=C.UTF-8
+export LC_MONETARY=C.UTF-8
+export LC_NAME=C.UTF-8
+export LC_NUMERIC=C.UTF-8
+export LC_PAPER=C.UTF-8
+export LC_TELEPHONE=C.UTF-8
+export LC_TIME=C.UTF-8
Review Comment:
#41247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41238: [Release] Use UTF-8 as the default encoding to upload binary [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #41242:
URL: https://github.com/apache/arrow/pull/41242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41238: [Release] Use UTF-8 as the default encoding to upload binary [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41242:
URL: https://github.com/apache/arrow/pull/41242#issuecomment-2063069650
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit d49b62d9c46f3b875402e39a94418a92fa14c5ca.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/23961406405) has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41238: [Release] Use UTF-8 as the default encoding to upload binary [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41242:
URL: https://github.com/apache/arrow/pull/41242#issuecomment-2060255083
I used this for 16.0.0 RC0 and confirmed that UTF-8 is used by debug print.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org