You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by lei-xia <gi...@git.apache.org> on 2018/04/16 18:58:26 UTC

[GitHub] helix pull request #183: Fix race-condition issue that could block ZkClient ...

GitHub user lei-xia opened a pull request:

    https://github.com/apache/helix/pull/183

    Fix race-condition issue that could block ZkClient event thread in CallbackHandler.

    1) Replace native batch callback handling thread with DedupEventCallbackProcessor, so the queue is deduplicated when event gets enqueued, instead of at the time of dequeue.
    
    2) Shutdown and clean up the processor properly when CallbackHanlder is reset().
    
    3) Add a flag to indicated whether the CallbackHandler is reset. If reset, do not enqueue further event into the batch callback queue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lei-xia/helix master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #183
    
----
commit a25305eb83c3226d028e39c27a70293c2576756e
Author: Lei Xia <lx...@...>
Date:   2018-04-16T18:38:26Z

    Fix race-condition issue that could block ZkClient event thread in CallbackHandler.

----


---

[GitHub] helix pull request #183: Fix race-condition issue that could block ZkClient ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/helix/pull/183


---