You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bigtop.apache.org by "Kengo Seki (Jira)" <ji...@apache.org> on 2021/02/16 03:48:00 UTC
[jira] [Assigned] (BIGTOP-3400) Clean up or disable husky installed
via packaging Kibana
[ https://issues.apache.org/jira/browse/BIGTOP-3400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kengo Seki reassigned BIGTOP-3400:
----------------------------------
Assignee: Kengo Seki
> Clean up or disable husky installed via packaging Kibana
> --------------------------------------------------------
>
> Key: BIGTOP-3400
> URL: https://issues.apache.org/jira/browse/BIGTOP-3400
> Project: Bigtop
> Issue Type: Improvement
> Reporter: Kengo Seki
> Assignee: Kengo Seki
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Packaging Kibana installs git hooks into Bigtop's .git directory.
> {code}
> $ ls .git/hooks
> applypatch-msg.sample post-update.sample prepare-commit-msg.sample pre-receive.sample
> commit-msg.sample pre-applypatch.sample pre-push.sample update.sample
> fsmonitor-watchman.sample pre-commit.sample pre-rebase.sample
> $ ./gradlew kibana-pkg
> (snip)
> > husky@0.8.1 install /home/sekikn/repos/bigtop/output/kibana/kibana-5.4.1/node_modules/husky
> > node ./bin/install.js
> husky
> setting up hooks in .git/hooks/
> done
> (snip)
> BUILD SUCCESSFUL in 15m 44s
> $ ls .git/hooks
> applypatch-msg.sample post-rewrite pre-commit.sample pre-rebase
> commit-msg.sample post-update.sample prepare-commit-msg.sample pre-rebase.sample
> fsmonitor-watchman.sample pre-applypatch.sample pre-push pre-receive.sample
> post-merge pre-commit pre-push.sample update.sample
> {code}
> But it doesn't work as expected once the output/kibana directory is cleaned.
> {code}
> $ ./gradlew kibana-clean
> $ git pull origin master
> From https://github.com/sekikn/bigtop
> * branch master -> FETCH_HEAD
> Already up to date.
> $ git push origin master
> .git/hooks/pre-push: 4: cd: can't cd to output/kibana/kibana-5.4.1
> {code}
> These hooks are not intentionally installed, so I think they should be removed when the build is finished, or disabled from the beginning.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)