You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/03/18 19:17:52 UTC

[kudu-CR] block bloom filter: quell warning in release build

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15478


Change subject: block_bloom_filter: quell warning in release build
......................................................................

block_bloom_filter: quell warning in release build

Saw this when building in release mode.

[687/1584] Building CXX object src/kudu/uti...u_util_exported.dir/block_bloom_filter.cc.o
../../src/kudu/util/block_bloom_filter.cc: In constructor ‘kudu::BlockBloomFilter::BlockBloomFilter(kudu::BlockBloomFilterBufferAllocatorIf*)’:
../../src/kudu/util/block_bloom_filter.cc:93:42: warning: statement has no effect [-Wunused-value]
   DCHECK_NOTNULL(bucket_insert_func_ptr_);
                                          ^
../../src/kudu/util/block_bloom_filter.cc:94:40: warning: statement has no effect [-Wunused-value]
   DCHECK_NOTNULL(bucket_find_func_ptr_);
                                        ^
../../src/kudu/util/block_bloom_filter.cc:95:43: warning: statement has no effect [-Wunused-value]
   DCHECK_NOTNULL(or_equal_array_func_ptr_);
                                           ^

From glog/logging.h:
 You may see warnings in release mode if you don't use the return
 value of DCHECK_NOTNULL. Please just use DCHECK for such cases.

Change-Id: I6fc2e715ea156dea6cb99369d84e6bc3c338fca0
---
M src/kudu/util/block_bloom_filter.cc
1 file changed, 8 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/15478/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6fc2e715ea156dea6cb99369d84e6bc3c338fca0
Gerrit-Change-Number: 15478
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>

[kudu-CR] block bloom filter: quell warning in release build

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15478 )

Change subject: block_bloom_filter: quell warning in release build
......................................................................

block_bloom_filter: quell warning in release build

Saw this when building in release mode.

[687/1584] Building CXX object src/kudu/uti...u_util_exported.dir/block_bloom_filter.cc.o
../../src/kudu/util/block_bloom_filter.cc: In constructor ‘kudu::BlockBloomFilter::BlockBloomFilter(kudu::BlockBloomFilterBufferAllocatorIf*)’:
../../src/kudu/util/block_bloom_filter.cc:93:42: warning: statement has no effect [-Wunused-value]
   DCHECK_NOTNULL(bucket_insert_func_ptr_);
                                          ^
../../src/kudu/util/block_bloom_filter.cc:94:40: warning: statement has no effect [-Wunused-value]
   DCHECK_NOTNULL(bucket_find_func_ptr_);
                                        ^
../../src/kudu/util/block_bloom_filter.cc:95:43: warning: statement has no effect [-Wunused-value]
   DCHECK_NOTNULL(or_equal_array_func_ptr_);
                                           ^

From glog/logging.h:
 You may see warnings in release mode if you don't use the return
 value of DCHECK_NOTNULL. Please just use DCHECK for such cases.

Change-Id: I6fc2e715ea156dea6cb99369d84e6bc3c338fca0
Reviewed-on: http://gerrit.cloudera.org:8080/15478
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/util/block_bloom_filter.cc
1 file changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fc2e715ea156dea6cb99369d84e6bc3c338fca0
Gerrit-Change-Number: 15478
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] block bloom filter: quell warning in release build

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15478 )

Change subject: block_bloom_filter: quell warning in release build
......................................................................


Patch Set 2: Code-Review+1

Thanks for fixing this, Andrew!


-- 
To view, visit http://gerrit.cloudera.org:8080/15478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fc2e715ea156dea6cb99369d84e6bc3c338fca0
Gerrit-Change-Number: 15478
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Mar 2020 20:39:18 +0000
Gerrit-HasComments: No

[kudu-CR] block bloom filter: quell warning in release build

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15478 )

Change subject: block_bloom_filter: quell warning in release build
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fc2e715ea156dea6cb99369d84e6bc3c338fca0
Gerrit-Change-Number: 15478
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Mar 2020 20:35:06 +0000
Gerrit-HasComments: No