You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/02/15 17:17:33 UTC
[GitHub] flink pull request #3327: [FLINK-5616] [tests] Harden YarnIntraNonHaMasterSe...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/3327
[FLINK-5616] [tests] Harden YarnIntraNonHaMasterServicesTest.testClosingReportsToLeader
Remove the verify timeout and instead set an increased unit test timeout of 5 seconds.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink FLINK-5616
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3327.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3327
----
commit 87342d549b7181013d20873453468e5fbd900cbf
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-02-15T17:15:50Z
[FLINK-5616] [tests] Harden YarnIntraNonHaMasterServicesTest.testClosingReportsToLeader
Remove the verify timeout and instead set an increased unit test timeout of 5 seconds.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3327: [FLINK-5616] [tests] Harden YarnIntraNonHaMasterServicesT...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3327
True, this does not make much sense, what I've done here. Somehow I was under the assumption that `verify` will block until the call happened when I wrote it. Will correct it. Thanks for the review :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3327: [FLINK-5616] [tests] Harden YarnIntraNonHaMasterServicesT...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3327
Travis now passed :-) Merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3327: [FLINK-5616] [tests] Harden YarnIntraNonHaMasterServicesT...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3327
I am wondering if this is the same as the original timeout meaning.
I though that using `verify` with a timeout will wait for a while until the call must have happened. Without the timeout, the verification will fail if the call had not happened by the time the verification runs.
Adding the timeout to the test as a whole means that the test may not take longer than that timeout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3327: [FLINK-5616] [tests] Harden YarnIntraNonHaMasterSe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3327
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---