You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ha...@apache.org on 2014/11/29 21:59:27 UTC

git commit: [flex-tlf] [refs/heads/develop] - insertColumnAt columns.length was failing. This is now fixed. There's no check for merged cells which will cause it to fail as well. It might be a good idea to add more complex logic to handle that, but curre

Repository: flex-tlf
Updated Branches:
  refs/heads/develop 0b00e3aab -> 47ea3543e


insertColumnAt columns.length was failing. This is now fixed.
There's no check for merged cells which will cause it to fail as well. It might be a good idea to add more complex logic to handle that, but currently adding columns to tables with merged cells will cause all kinds of trouble and we do not support that.


Project: http://git-wip-us.apache.org/repos/asf/flex-tlf/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-tlf/commit/47ea3543
Tree: http://git-wip-us.apache.org/repos/asf/flex-tlf/tree/47ea3543
Diff: http://git-wip-us.apache.org/repos/asf/flex-tlf/diff/47ea3543

Branch: refs/heads/develop
Commit: 47ea3543e90774a672d1560eae527d0fac89baa9
Parents: 0b00e3a
Author: Harbs <ha...@in-tools.com>
Authored: Sat Nov 29 22:59:14 2014 +0200
Committer: Harbs <ha...@in-tools.com>
Committed: Sat Nov 29 22:59:14 2014 +0200

----------------------------------------------------------------------
 textLayout/src/flashx/textLayout/elements/TableElement.as | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/47ea3543/textLayout/src/flashx/textLayout/elements/TableElement.as
----------------------------------------------------------------------
diff --git a/textLayout/src/flashx/textLayout/elements/TableElement.as b/textLayout/src/flashx/textLayout/elements/TableElement.as
index c7f2fbc..beba4e7 100644
--- a/textLayout/src/flashx/textLayout/elements/TableElement.as
+++ b/textLayout/src/flashx/textLayout/elements/TableElement.as
@@ -476,7 +476,10 @@ package flashx.textLayout.elements
 				}
 				cellIdx = getCellIndex(rowIdx,idx);
 				if(cellIdx < 0)
-					cellIdx = numChildren;
+				{
+					cellIdx = getCellIndex(rowIdx,idx-1);
+					cellIdx++;
+				}
 				
 				if(rowIdx < numRows){
 					addChildAt(cellIdx,cell);