You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/07/08 23:08:06 UTC
[jira] [Commented] (AMQ-5265) JMX destination entires fail due to
race condition in MBeanBridgeDestination
[ https://issues.apache.org/jira/browse/AMQ-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055542#comment-14055542 ]
ASF GitHub Bot commented on AMQ-5265:
-------------------------------------
GitHub user jgenender opened a pull request:
https://github.com/apache/activemq/pull/31
AMQ-5265 - fix race condition for task
AMQ-5265 - fix race condition for task in MBeanBridgeDestination for running the purgeInactiveDestinationViewTask and the execution of onOutboundMessage and onInboundMessage
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jgenender/activemq trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit a519384355d0e4acc74e9871ea33e2ee1d113ed5
Author: Jeff Genender <jg...@savoirtech.com>
Date: 2014-07-08T21:05:41Z
AMQ-5265 - fix race condition for task
----
> JMX destination entires fail due to race condition in MBeanBridgeDestination
> ----------------------------------------------------------------------------
>
> Key: AMQ-5265
> URL: https://issues.apache.org/jira/browse/AMQ-5265
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.9.1, 5.10.0
> Reporter: Jeff Genender
> Attachments: AMQ-5265.patch
>
>
> JMX statistics on destinations creates a race condition in the MBeanBridgeDestination's onInboundMessage, onOutboundMessage, and the purgeInactiveDestinationView task. If the task fires and removes the objectName while the onInboundMessage or onOutboundMessage fires, it will spit out warnings of it already being created if multiple threads are running. The fix is to properly synchronize in the purgeInactiveDestinationView and also be sure it cleans up itself in the destinationObjectNameMap.
> Patch is attached as is a git pull request (for whatever is easier)
--
This message was sent by Atlassian JIRA
(v6.2#6252)