You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by "Asanka Abeysinghe (JIRA)" <ji...@apache.org> on 2008/06/24 13:12:45 UTC

[jira] Created: (SYNAPSE-373) Remove the BeginString (Tag 8) validation of the FIX messages

Remove the BeginString (Tag 8) validation of the FIX messages
-------------------------------------------------------------

                 Key: SYNAPSE-373
                 URL: https://issues.apache.org/jira/browse/SYNAPSE-373
             Project: Synapse
          Issue Type: Improvement
          Components: Transports
    Affects Versions: 1.2
            Reporter: Asanka Abeysinghe
            Priority: Minor


Remove the FIX message version validation to support Synapse proxy service to bridge two FIX endpoints with different versions. E.g. FIX.4.0 and FIX.4.1 (only compatible messages between two versions).

Current Synapse FIX implementation got a stopper for the above requirement because it validates the incoming message version and the outgoing message version defined in the FIX message header (BeginString/Tag 10).

Validations done inside the  class org.apache.synapse.transport.fix.FIXTransportSender.

Quickfix/j (FIX engine used in Synapse) will be doing the FIX message validations based on the session configuration and the FIX-specification, so it is not required to do FIX validations inside the Synapse transport layer.

A synapse user can make messages compatible by defining proper message definitions/ FIX-specs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-373) Remove the BeginString (Tag 8) validation of the FIX messages

Posted by "Hiranya Jayathilaka (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiranya Jayathilaka updated SYNAPSE-373:
----------------------------------------

    Attachment: BeginStrValidation.patch

Changes Made:
* Introduced a new service parameter (transport.fix.BeginStringValidation)
* Disabled BeginString validation

I have successfully tested the changes by bridging a FIX 4.3 session with a FIX 4.4 session. Previously supported scenarios are also still valid. No documentation changes are required.

If the patch is ok by others we can get this checked into the code base.

> Remove the BeginString (Tag 8) validation of the FIX messages
> -------------------------------------------------------------
>
>                 Key: SYNAPSE-373
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-373
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 1.2
>            Reporter: Asanka Abeysinghe
>            Assignee: Hiranya Jayathilaka
>            Priority: Minor
>         Attachments: BeginStrValidation.patch
>
>
> Remove the FIX message version validation to support Synapse proxy service to bridge two FIX endpoints with different versions. E.g. FIX.4.0 and FIX.4.1 (only compatible messages between two versions).
> Current Synapse FIX implementation got a stopper for the above requirement because it validates the incoming message version and the outgoing message version defined in the FIX message header (BeginString/Tag 10).
> Validations done inside the  class org.apache.synapse.transport.fix.FIXTransportSender.
> Quickfix/j (FIX engine used in Synapse) will be doing the FIX message validations based on the session configuration and the FIX-specification, so it is not required to do FIX validations inside the Synapse transport layer.
> A synapse user can make messages compatible by defining proper message definitions/ FIX-specs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-373) Remove the BeginString (Tag 8) validation of the FIX messages

Posted by "Hiranya Jayathilaka (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607846#action_12607846 ] 

Hiranya Jayathilaka commented on SYNAPSE-373:
---------------------------------------------

BeginString validation feature can be made optional with minimal effort. Since bridging different types of FIX sessions is a very useful usecase we can have this feature disabled by default.

However then we must use DeliverTo* and OnBehalf* fields when there are multiple sessions connected to the same acceptor.

> Remove the BeginString (Tag 8) validation of the FIX messages
> -------------------------------------------------------------
>
>                 Key: SYNAPSE-373
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-373
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 1.2
>            Reporter: Asanka Abeysinghe
>            Assignee: Hiranya Jayathilaka
>            Priority: Minor
>
> Remove the FIX message version validation to support Synapse proxy service to bridge two FIX endpoints with different versions. E.g. FIX.4.0 and FIX.4.1 (only compatible messages between two versions).
> Current Synapse FIX implementation got a stopper for the above requirement because it validates the incoming message version and the outgoing message version defined in the FIX message header (BeginString/Tag 10).
> Validations done inside the  class org.apache.synapse.transport.fix.FIXTransportSender.
> Quickfix/j (FIX engine used in Synapse) will be doing the FIX message validations based on the session configuration and the FIX-specification, so it is not required to do FIX validations inside the Synapse transport layer.
> A synapse user can make messages compatible by defining proper message definitions/ FIX-specs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-373) Remove the BeginString (Tag 8) validation of the FIX messages

Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607852#action_12607852 ] 

Ruwan Linton commented on SYNAPSE-373:
--------------------------------------

Hiranya, you should be able to commit now with your apache id :-)

> Remove the BeginString (Tag 8) validation of the FIX messages
> -------------------------------------------------------------
>
>                 Key: SYNAPSE-373
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-373
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 1.2
>            Reporter: Asanka Abeysinghe
>            Assignee: Hiranya Jayathilaka
>            Priority: Minor
>         Attachments: BeginStrValidation.patch
>
>
> Remove the FIX message version validation to support Synapse proxy service to bridge two FIX endpoints with different versions. E.g. FIX.4.0 and FIX.4.1 (only compatible messages between two versions).
> Current Synapse FIX implementation got a stopper for the above requirement because it validates the incoming message version and the outgoing message version defined in the FIX message header (BeginString/Tag 10).
> Validations done inside the  class org.apache.synapse.transport.fix.FIXTransportSender.
> Quickfix/j (FIX engine used in Synapse) will be doing the FIX message validations based on the session configuration and the FIX-specification, so it is not required to do FIX validations inside the Synapse transport layer.
> A synapse user can make messages compatible by defining proper message definitions/ FIX-specs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Resolved: (SYNAPSE-373) Remove the BeginString (Tag 8) validation of the FIX messages

Posted by "Hiranya Jayathilaka (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiranya Jayathilaka resolved SYNAPSE-373.
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: NIGHTLY

Fixed on SVN trunk. Made the following changes;

 * introduced a new service parameter (transport.fix.BeginStringValidation)
 * disabled BeginString validation

I tested the new feature successfully by bridging a FIX 4.3 session with a FIX 4.4 session. 

> Remove the BeginString (Tag 8) validation of the FIX messages
> -------------------------------------------------------------
>
>                 Key: SYNAPSE-373
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-373
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 1.2
>            Reporter: Asanka Abeysinghe
>            Assignee: Hiranya Jayathilaka
>            Priority: Minor
>             Fix For: NIGHTLY
>
>         Attachments: BeginStrValidation.patch
>
>
> Remove the FIX message version validation to support Synapse proxy service to bridge two FIX endpoints with different versions. E.g. FIX.4.0 and FIX.4.1 (only compatible messages between two versions).
> Current Synapse FIX implementation got a stopper for the above requirement because it validates the incoming message version and the outgoing message version defined in the FIX message header (BeginString/Tag 10).
> Validations done inside the  class org.apache.synapse.transport.fix.FIXTransportSender.
> Quickfix/j (FIX engine used in Synapse) will be doing the FIX message validations based on the session configuration and the FIX-specification, so it is not required to do FIX validations inside the Synapse transport layer.
> A synapse user can make messages compatible by defining proper message definitions/ FIX-specs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Assigned: (SYNAPSE-373) Remove the BeginString (Tag 8) validation of the FIX messages

Posted by "Hiranya Jayathilaka (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiranya Jayathilaka reassigned SYNAPSE-373:
-------------------------------------------

    Assignee: Hiranya Jayathilaka

> Remove the BeginString (Tag 8) validation of the FIX messages
> -------------------------------------------------------------
>
>                 Key: SYNAPSE-373
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-373
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 1.2
>            Reporter: Asanka Abeysinghe
>            Assignee: Hiranya Jayathilaka
>            Priority: Minor
>
> Remove the FIX message version validation to support Synapse proxy service to bridge two FIX endpoints with different versions. E.g. FIX.4.0 and FIX.4.1 (only compatible messages between two versions).
> Current Synapse FIX implementation got a stopper for the above requirement because it validates the incoming message version and the outgoing message version defined in the FIX message header (BeginString/Tag 10).
> Validations done inside the  class org.apache.synapse.transport.fix.FIXTransportSender.
> Quickfix/j (FIX engine used in Synapse) will be doing the FIX message validations based on the session configuration and the FIX-specification, so it is not required to do FIX validations inside the Synapse transport layer.
> A synapse user can make messages compatible by defining proper message definitions/ FIX-specs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org