[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #3508: [Enhancement] Do some code optimization[BeanUtilsTest]

["Alonexc (via GitHub)" <gi...@apache.org>]

Alonexc opened a new issue, #3508:
URL: https://github.com/apache/incubator-eventmesh/issues/3508

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/226834729-ae1d9e87-f685-4f26-b196-fa2dd8fe9e60.png)
   ![image](https://user-images.githubusercontent.com/91315508/226834739-0ecf4c05-33ef-4c76-a8ea-0ec17bb165e9.png)
   ![image](https://user-images.githubusercontent.com/91315508/226834759-0fade627-49f5-41bf-99aa-d594251ee909.png)
   ![image](https://user-images.githubusercontent.com/91315508/226834769-973c3588-49dc-4404-8b51-5b80af4cd8d2.png)
   located at:
   eventmesh-storage/eventmesh-storage-rocketmq/src/test/java/org/apache/rocketmq/utils/BeanUtilsTest.java line 32,88-94,102-112
   
   
   ### Describe the solution you'd like
   
   a. Add final.[line 32]
   b. Remove invalid code.[line 88,106]
   c. Swap actual and expected values.[line 89-94,102,107-112]
   d. Variable is already assigned to this value[line 104]
   e.g.
   ![image](https://user-images.githubusercontent.com/91315508/226835006-3b0b6faf-3c32-4a8e-94e9-0cd1816e8c03.png)
   ![image](https://user-images.githubusercontent.com/91315508/226835028-abf44d99-2e45-4733-ab9e-070f0b421c39.png)
   ![image](https://user-images.githubusercontent.com/91315508/226835037-cda7f61d-e8fb-4cd8-aaef-50315247c933.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] xwm1992 closed issue #3508: [Enhancement] Do some code optimization[BeanUtilsTest]

["xwm1992 (via GitHub)" <gi...@apache.org>]

xwm1992 closed issue #3508: [Enhancement] Do some code optimization[BeanUtilsTest]
URL: https://github.com/apache/eventmesh/issues/3508


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org