You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/15 20:09:23 UTC
[GitHub] [incubator-superset] nytai opened a new pull request #9814: build: conditionally run fossa check based on dependency file changes
nytai opened a new pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Last week fossa command became flaky and failed to install. This blocked PRs from passing build and merging. A PR to fix this was opened (https://github.com/apache/incubator-superset/pull/9769) but it didn't fix it. Eventually fossa started working again. This PR introduces a check for the fossa command and logs, but does not fail the build, if the fossa command cannot be found.
How important is it to have the fossa check? I haven't had much experience with it, is it actively monitored. Should we fail the build if a fossa report cannot be generated?
If the fossa check is absolutely necessary, can we only run it when dependency files change, eg requirements*.txt, package*.json?
#### UPDATE FROM DISCUSSION
This PR checks for changes to dependency files (\*.package\*\.json and \*.requirements\*\.json) and runs fossa *only* if those files have changed.
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
- [x] build passes
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on pull request #9814: build: skip fossa check if it fails to install
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629410233
We can skip the fossa step based on files changed. The whole job won't be skipped though, so it'll still run and register pass/fail for the required check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9814: build: conditionally run fossa check based on dependency file changes
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629448215
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=h1) Report
> Merging [#9814](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed1d030667c50e48f1d8a3ecdc7772a005d173a0&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9814 +/- ##
==========================================
+ Coverage 70.84% 70.89% +0.05%
==========================================
Files 588 585 -3
Lines 30475 30427 -48
Branches 3154 3152 -2
==========================================
- Hits 21589 21572 -17
+ Misses 8773 8744 -29
+ Partials 113 111 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.68% <ø> (+0.03%)` | :arrow_up: |
| #javascript | `59.25% <ø> (+0.22%)` | :arrow_up: |
| #python | `71.02% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.13% <0.00%> (ø)` | |
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | | |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `12.50% <0.00%> (+4.50%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `72.72% <0.00%> (+6.81%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=footer). Last update [ed1d030...0dfec1e](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9814: build: conditionally run fossa check based on dependency files changes
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629448215
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=h1) Report
> Merging [#9814](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed1d030667c50e48f1d8a3ecdc7772a005d173a0&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9814 +/- ##
==========================================
+ Coverage 70.84% 70.89% +0.05%
==========================================
Files 588 585 -3
Lines 30475 30427 -48
Branches 3154 3152 -2
==========================================
- Hits 21589 21572 -17
+ Misses 8773 8744 -29
+ Partials 113 111 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.68% <ø> (+0.03%)` | :arrow_up: |
| #javascript | `59.25% <ø> (+0.22%)` | :arrow_up: |
| #python | `71.02% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.13% <0.00%> (ø)` | |
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <0.00%> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | | |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `12.50% <0.00%> (+4.50%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `72.72% <0.00%> (+6.81%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=footer). Last update [ed1d030...ab7139f](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9814: build: conditionally run fossa check based on dependency files changes
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629448215
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=h1) Report
> Merging [#9814](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed1d030667c50e48f1d8a3ecdc7772a005d173a0&el=desc) will **decrease** coverage by `6.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9814 +/- ##
==========================================
- Coverage 70.84% 64.31% -6.53%
==========================================
Files 588 533 -55
Lines 30475 29079 -1396
Branches 3154 2804 -350
==========================================
- Hits 21589 18703 -2886
- Misses 8773 10198 +1425
- Partials 113 178 +65
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.68% <ø> (+0.03%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `70.99% <ø> (-0.04%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-87.10%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | `7.69% <0.00%> (-79.81%)` | :arrow_down: |
| ... and [193 more](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=footer). Last update [ed1d030...ab7139f](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai edited a comment on pull request #9814: build: skip fossa check if it fails to install
Posted by GitBox <gi...@apache.org>.
nytai edited a comment on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629410233
We can skip the fossa **step** based on files changed. The whole job won't be skipped though, so it'll still run and register pass/fail for the required check. The key is to put the condition on the step, not the whole job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda merged pull request #9814: build: conditionally run fossa check based on dependency file changes
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #9814: build: skip fossa check if it fails to install
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629448215
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=h1) Report
> Merging [#9814](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed1d030667c50e48f1d8a3ecdc7772a005d173a0&el=desc) will **decrease** coverage by `0.16%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9814 +/- ##
==========================================
- Coverage 70.84% 70.67% -0.17%
==========================================
Files 588 585 -3
Lines 30475 30427 -48
Branches 3154 3152 -2
==========================================
- Hits 21589 21505 -84
- Misses 8773 8804 +31
- Partials 113 118 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.79% <ø> (-0.86%)` | :arrow_down: |
| #javascript | `59.25% <ø> (+0.22%)` | :arrow_up: |
| #python | `71.02% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `12.50% <ø> (+4.50%)` | :arrow_up: |
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.13% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `76.47% <0.00%> (-10.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.22% <0.00%> (-5.60%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=footer). Last update [ed1d030...a649839](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9814: build: conditionally run fossa check based on dependency files changes
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629448215
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=h1) Report
> Merging [#9814](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed1d030667c50e48f1d8a3ecdc7772a005d173a0&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9814 +/- ##
==========================================
- Coverage 70.84% 70.68% -0.16%
==========================================
Files 588 585 -3
Lines 30475 30427 -48
Branches 3154 3152 -2
==========================================
- Hits 21589 21507 -82
- Misses 8773 8802 +29
- Partials 113 118 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.86% <ø> (-0.79%)` | :arrow_down: |
| #javascript | `59.25% <ø> (+0.22%)` | :arrow_up: |
| #python | `71.02% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `76.47% <0.00%> (-10.30%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `81.34% <0.00%> (-2.24%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (-1.29%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-1.08%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=footer). Last update [ed1d030...18ac077](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9814: build: conditionally run fossa check based on dependency files changes
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629448215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9814: build: conditionally run fossa check based on dependency file changes
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629448215
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=h1) Report
> Merging [#9814](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed1d030667c50e48f1d8a3ecdc7772a005d173a0&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9814 +/- ##
==========================================
+ Coverage 70.84% 70.89% +0.05%
==========================================
Files 588 585 -3
Lines 30475 30427 -48
Branches 3154 3152 -2
==========================================
- Hits 21589 21572 -17
+ Misses 8773 8744 -29
+ Partials 113 111 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.68% <ø> (+0.03%)` | :arrow_up: |
| #javascript | `59.25% <ø> (+0.22%)` | :arrow_up: |
| #python | `71.02% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.13% <0.00%> (ø)` | |
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <0.00%> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | | |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `12.50% <0.00%> (+4.50%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `72.72% <0.00%> (+6.81%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=footer). Last update [ed1d030...0dfec1e](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on pull request #9814: build: skip fossa check if it fails to install
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629377372
I suppose we could. I don't think it'll really fix it though, as when it was failing I reran the pr a couple times and it always failed. My guess is the script broke for a while then eventually got fixed.
How do we feel about conditionally running this only when dependency files change? I think that's a fair tradeoff in security/efficiency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9814: build: conditionally run fossa check based on dependency file changes
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629448215
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=h1) Report
> Merging [#9814](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed1d030667c50e48f1d8a3ecdc7772a005d173a0&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9814 +/- ##
==========================================
+ Coverage 70.84% 70.88% +0.04%
==========================================
Files 588 585 -3
Lines 30475 30427 -48
Branches 3154 3152 -2
==========================================
- Hits 21589 21569 -20
+ Misses 8773 8747 -26
+ Partials 113 111 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.61% <ø> (-0.04%)` | :arrow_down: |
| #javascript | `59.25% <ø> (+0.22%)` | :arrow_up: |
| #python | `71.02% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.13% <0.00%> (ø)` | |
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <0.00%> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | | |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `12.50% <0.00%> (+4.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=footer). Last update [ed1d030...0dfec1e](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9814: build: conditionally run fossa check based on dependency files changes
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629448215
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=h1) Report
> Merging [#9814](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed1d030667c50e48f1d8a3ecdc7772a005d173a0&el=desc) will **decrease** coverage by `4.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9814 +/- ##
==========================================
- Coverage 70.84% 66.03% -4.81%
==========================================
Files 588 585 -3
Lines 30475 30427 -48
Branches 3154 3152 -2
==========================================
- Hits 21589 20092 -1497
- Misses 8773 10154 +1381
- Partials 113 181 +68
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.25% <ø> (+0.22%)` | :arrow_up: |
| #python | `70.79% <ø> (-0.23%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `0.00% <ø> (-8.00%)` | :arrow_down: |
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <ø> (-0.23%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [148 more](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=footer). Last update [ed1d030...ab7139f](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai closed pull request #9814: build: conditionally run fossa check based on dependency file changes
Posted by GitBox <gi...@apache.org>.
nytai closed pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on pull request #9814: build: skip fossa check if it fails to install
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629402044
Except for when someone bumps a lib :). I think it makes sense to limit its cadence to only run when a `requirements.txt` / `package.json` file changes. This will be tricky, however as we still want to require this check, and skipped checks can't be required...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9814: build: conditionally run fossa check based on dependency files changes
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629448215
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=h1) Report
> Merging [#9814](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed1d030667c50e48f1d8a3ecdc7772a005d173a0&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9814 +/- ##
==========================================
+ Coverage 70.84% 70.88% +0.04%
==========================================
Files 588 585 -3
Lines 30475 30427 -48
Branches 3154 3152 -2
==========================================
- Hits 21589 21568 -21
+ Misses 8773 8747 -26
+ Partials 113 112 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.63% <ø> (-0.01%)` | :arrow_down: |
| #javascript | `59.25% <ø> (+0.22%)` | :arrow_up: |
| #python | `71.02% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `88.76% <0.00%> (-1.13%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.15% <0.00%> (-0.66%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.13% <0.00%> (ø)` | |
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <0.00%> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | | |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `12.50% <0.00%> (+4.50%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `72.72% <0.00%> (+6.81%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=footer). Last update [ed1d030...ab7139f](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9814: build: conditionally run fossa check based on dependency files changes
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629448215
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=h1) Report
> Merging [#9814](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed1d030667c50e48f1d8a3ecdc7772a005d173a0&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9814 +/- ##
==========================================
- Coverage 70.84% 70.68% -0.16%
==========================================
Files 588 585 -3
Lines 30475 30427 -48
Branches 3154 3152 -2
==========================================
- Hits 21589 21507 -82
- Misses 8773 8802 +29
- Partials 113 118 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.86% <ø> (-0.79%)` | :arrow_down: |
| #javascript | `59.25% <ø> (+0.22%)` | :arrow_up: |
| #python | `71.02% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `76.47% <0.00%> (-10.30%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `81.34% <0.00%> (-2.24%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (-1.29%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-1.08%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=footer). Last update [ed1d030...dc17530](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #9814: build: skip fossa check if it fails to install
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629389195
I believe the fossa requirement is only really necessary when we're publishing a new apache release, as we need to guarantee all the code is licensed properly. It's good to have it running on every PR so a new dependency that doesn't comply won't sneak in, but I don't think we'd actually be violating anything as long as it's run and passes prior to releases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9814: build: conditionally run fossa check based on dependency files changes
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629448215
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=h1) Report
> Merging [#9814](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed1d030667c50e48f1d8a3ecdc7772a005d173a0&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9814 +/- ##
==========================================
+ Coverage 70.84% 70.89% +0.05%
==========================================
Files 588 585 -3
Lines 30475 30427 -48
Branches 3154 3152 -2
==========================================
- Hits 21589 21572 -17
+ Misses 8773 8744 -29
+ Partials 113 111 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.68% <ø> (+0.03%)` | :arrow_up: |
| #javascript | `59.25% <ø> (+0.22%)` | :arrow_up: |
| #python | `71.02% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.13% <0.00%> (ø)` | |
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <0.00%> (ø)` | |
| [...-frontend/src/explore/controlPanels/Shared\_NVD3.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfTlZEMy5qcw==) | | |
| [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | | |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `12.50% <0.00%> (+4.50%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9814/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `72.72% <0.00%> (+6.81%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=footer). Last update [ed1d030...ab7139f](https://codecov.io/gh/apache/incubator-superset/pull/9814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on pull request #9814: build: skip fossa check if it fails to install
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629375126
Is there a way to retry the installation? I worry that this will allow PRs to slip in which might violate the rulez.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on pull request #9814: build: skip fossa check if it fails to install
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #9814:
URL: https://github.com/apache/incubator-superset/pull/9814#issuecomment-629369226
@mistercrunch would be great to get your feedback on this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org