You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Thomas Koch (Updated) (JIRA)" <ji...@apache.org> on 2011/10/28 16:20:32 UTC

[jira] [Updated] (ZOOKEEPER-1267) closeSession flag in finalRequestProcessor is superfluous

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Koch updated ZOOKEEPER-1267:
-----------------------------------

    Attachment: ZOOKEEPER-1267.patch
    
> closeSession flag in finalRequestProcessor is superfluous
> ---------------------------------------------------------
>
>                 Key: ZOOKEEPER-1267
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1267
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>            Priority: Trivial
>         Attachments: ZOOKEEPER-1267.patch
>
>
> The variable can be removed and instead where it is evaluated one can just check whether the request.type was OpCode.closesession. Removes one indirection from your head in a method that's long enough already.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira