You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "HaoYang670 (via GitHub)" <gi...@apache.org> on 2023/04/20 08:02:49 UTC

[GitHub] [kyuubi] HaoYang670 opened a new issue, #4738: [Bug] Cannot get the `GROUP` shared level Engine info using admin RESTful API.

HaoYang670 opened a new issue, #4738:
URL: https://github.com/apache/kyuubi/issues/4738

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/kyuubi/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Describe the bug
   
   Details are here: https://github.com/apache/kyuubi/discussions/4684
   
   ### Affects Version(s)
   
   1.7.0 / master
   
   ### Kyuubi Server Log Output
   
   _No response_
   
   ### Kyuubi Engine Log Output
   
   _No response_
   
   ### Kyuubi Server Configurations
   
   _No response_
   
   ### Kyuubi Engine Configurations
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
   - [ ] No. I cannot submit a PR at this time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] zwangsheng commented on issue #4738: [Bug] Cannot get the `GROUP` shared level Engine info using admin RESTful API.

Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on issue #4738:
URL: https://github.com/apache/kyuubi/issues/4738#issuecomment-1515940715

   > Thank you @zwangsheng. Can I file a PR to fix this?
   
   Of course, the Kyuubi community welcomes contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] HaoYang670 commented on issue #4738: [Bug] Cannot get the `GROUP` shared level Engine info using admin RESTful API.

Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on issue #4738:
URL: https://github.com/apache/kyuubi/issues/4738#issuecomment-1515939343

   Thank you @zwangsheng. Can I file a PR to fix this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] HaoYang670 commented on issue #4738: [Bug] Cannot get the `GROUP` shared level Engine info using admin RESTful API.

Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on issue #4738:
URL: https://github.com/apache/kyuubi/issues/4738#issuecomment-1515912532

   Great! So how to get the primary group from `Engine`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] github-actions[bot] commented on issue #4738: [Bug] Cannot get the `GROUP` shared level Engine info using admin RESTful API.

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4738:
URL: https://github.com/apache/kyuubi/issues/4738#issuecomment-1515897680

   Hello @HaoYang670,
   Thanks for finding the time to report the issue!
   We really appreciate the community's efforts to improve Apache Kyuubi.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] zwangsheng commented on issue #4738: [Bug] Cannot get the `GROUP` shared level Engine info using admin RESTful API.

Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on issue #4738:
URL: https://github.com/apache/kyuubi/issues/4738#issuecomment-1515905013

   As https://github.com/apache/kyuubi/discussions/4684 tells:
   
   1. Engine register self with `/serverSpace_version_GROUP_engineType`/`primary group name`[/`subdomain`]
   
   2. RestApi find engine with `/serverSpace_version_CONNECTION_engineType`/`user`[/`subdomain`]
   
   3. We should respect design with `/serverSpace_version_GROUP_engineType`/`primary group name`[/`subdomain`]
   
   So, let's fix `AdminResource#getEngineSpace()`'s logic, keep same with `EngineRef#engineSpace`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] zwangsheng commented on issue #4738: [Bug] Cannot get the `GROUP` shared level Engine info using admin RESTful API.

Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on issue #4738:
URL: https://github.com/apache/kyuubi/issues/4738#issuecomment-1515937213

   > Great! So how to get the primary group from Engine ?
   
   Non-specific tips:
   
   Mark `sessionManager` in `KyuubiRestFrontendService`
   ```
   private[kyuubi] def sessionManager = be.sessionManager.asInstanceOf[KyuubiSessionManager]
   ```
   
   Then
   ```
   fe.sessionManager.groupProvider.primaryGroup(engine.getUser, fe.getConf.getAll.asJava)
   ```
   
   You can listen to PPMC's suggestion after start your PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] pan3793 closed issue #4738: [Bug] Cannot get the `GROUP` shared level Engine info using admin RESTful API.

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed issue #4738: [Bug] Cannot get the `GROUP` shared level Engine info using admin RESTful API.
URL: https://github.com/apache/kyuubi/issues/4738


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org