You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "ChengJie1053 (via GitHub)" <gi...@apache.org> on 2023/09/23 09:37:29 UTC
[GitHub] [incubator-streampark] ChengJie1053 opened a new pull request, #3169: [WIP][Feature] Support Flink 1.18 application submit
ChengJie1053 opened a new pull request, #3169:
URL: https://github.com/apache/incubator-streampark/pull/3169
Support Flink 1.18 application submit
issues: https://github.com/apache/incubator-streampark/issues/3166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] Al-assad commented on pull request #3169: [WIP][Feature] Support Flink 1.18 application submit
Posted by "Al-assad (via GitHub)" <gi...@apache.org>.
Al-assad commented on PR #3169:
URL: https://github.com/apache/incubator-streampark/pull/3169#issuecomment-1732500883
@ChengJie1053 Please note that there are some compilation errors at https://github.com/apache/incubator-streampark/actions/runs/6282946517/job/17062928571?pr=3169#step:4:4468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP][Feature] Support Flink 1.18 application submit [incubator-streampark]
Posted by "ChengJie1053 (via GitHub)" <gi...@apache.org>.
ChengJie1053 commented on PR #3169:
URL: https://github.com/apache/incubator-streampark/pull/3169#issuecomment-1778331983
> Thanks for your contribution. There are some code style issues, please fix it first. https://github.com/apache/incubator-streampark/actions/runs/6622142106/job/17987202488?pr=3169
Ok, thank you for reviewing the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP][Feature] Support Flink 1.18 application submit [incubator-streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #3169:
URL: https://github.com/apache/incubator-streampark/pull/3169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] ChengJie1053 commented on pull request #3169: [WIP][Feature] Support Flink 1.18 application submit
Posted by "ChengJie1053 (via GitHub)" <gi...@apache.org>.
ChengJie1053 commented on PR #3169:
URL: https://github.com/apache/incubator-streampark/pull/3169#issuecomment-1732785874
> https://github.com/apache/incubator-streampark/actions/runs/6282946517/job/17062928571?pr=3169#step:4:4468
Ok, thanks for reviewing the code，It is because maven warehouse does not have flink-1.18 dependency for the time being
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #3169: [WIP][Feature] Support Flink 1.18 application submit
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #3169:
URL: https://github.com/apache/incubator-streampark/pull/3169#issuecomment-1733659533
cc @ChengJie1053 Thanks for your contribution, but please make sure that the PR can compile locally and pass the test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP][Feature] Support Flink 1.18 application submit [incubator-streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #3169:
URL: https://github.com/apache/incubator-streampark/pull/3169#issuecomment-1778292471
Thanks for your contribution. There are some code style issues, please fix it first. https://github.com/apache/incubator-streampark/actions/runs/6622142050/job/17987197616?pr=3169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org