You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/16 15:43:56 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #4116: net: Add file_socket function

gustavonihei commented on pull request #4116:
URL: https://github.com/apache/incubator-nuttx/pull/4116#issuecomment-881542185


   I think overall it looks good.
   I've seen some other PRs with the same approach of changing the file operations to use `filep` structure instead of file descriptors. Could you explain the motivation for this refactor?
   My first impression it seems that it looks cleaner, but I'd like to have a better comprehension of this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org