You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "menghaoranss (via GitHub)" <gi...@apache.org> on 2026/07/31 09:50:52 UTC
[PR] Enforce lower case identifier policy for hive [shardingsphere]
menghaoranss opened a new pull request, #39290:
URL: https://github.com/apache/shardingsphere/pull/39290
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enforce lower case identifier policy for hive [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss merged PR #39290:
URL: https://github.com/apache/shardingsphere/pull/39290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enforce lower case identifier policy for hive [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss commented on PR #39290:
URL: https://github.com/apache/shardingsphere/pull/39290#issuecomment-5141815544
```markdown
### Result
**Review Result: Mergeable**
No code-correctness blockers were found at the reviewed public head.
### Evidence
- `HiveDatabaseMetaData.java:42` now reports `LOWER_CASE`, aligning schema/database-name formatting with Hive identifier behavior.
- `HiveIdentifierCasePolicyProvider.java:31` applies lowercase, case-insensitive normalization to quoted and unquoted identifiers.
- The provider is registered through SPI, and `HiveIdentifierCasePolicyProviderTest.java:40` verifies service discovery and normalization behavior.
- This matches the pinned Hive 4.0.1 behavior and [Apache Hive documentation](https://hive.apache.org/docs/latest/language/languagemanual-ddl/), which specifies that table and column names are case-insensitive.
- Focused unit tests: exit 0, `BUILD SUCCESS`.
- Scoped Checkstyle verification: exit 0, `BUILD SUCCESS`.
- Version verification used the manual primary-source checklist because `$source-driven-development` was unavailable.
### Coverage
- Reviewed head: `6ca31f75364f8f5d07760a529e36a73587f9dad5`
- Base: `9d7a10d933b16cf5b8569314d38961df62dbf11e`
- Requirements: PR title and description; no linked issue was provided.
- All five authoritative changed files were reviewed.
- Behavior clusters: Hive identifier metadata; identifier-policy SPI implementation and discovery.
- Completed lenses: root cause and behavior; blast radius and contracts; tests, runtime, and operations.
- Convergence pass found zero new independent candidates.
- Unresolved evidence gaps: none.
- This is a code-scope result only; CI was not reviewed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org