You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Pete MacKinnon (JIRA)" <qp...@incubator.apache.org> on 2009/06/18 18:52:07 UTC
[jira] Created: (QPID-1918) Patches/files for Windows QMF plug-in
support
Patches/files for Windows QMF plug-in support
---------------------------------------------
Key: QPID-1918
URL: https://issues.apache.org/jira/browse/QPID-1918
Project: Qpid
Issue Type: New Feature
Components: Qpid Managment Framework
Environment: Windows XP SP3, VC++ 9.0
Reporter: Pete MacKinnon
Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
Need Static builds (release and debug) for correct runtime integration with Condor:
src/broker.vcproj
src/client.vcproj
src/common.vcproj
src/qmfagent.vcproj
src/qmfconsole.vcproj
src/qpid.sln
src/qpidbroker.vcproj
- Changed to provide compile flags required for header file integration of
Posix types declared by both Qpid and Condor:
src/qpid/sys/windows/IntegerTypes.h
src/qpid/sys/windows/uuid.cpp
src/qpid/sys/windows/uuid.h
- Modified signature of PipeHandle ctor and fixed a Windows race condition in
the processing loop:
src/qpid/agent/ManagementAgentImpl.cpp
- Refactored the pipe code so that Condor can get a true socket fd it can
select on in daemon_core:
src/qpid/sys/Pipehandle.h
src/qpid/sys/posix/PipeHandle.cpp
src/qpid/sys/windows/PipeHandle.cpp
- Removed explicit dependency on Debug libs since we now have even more
targets. Added Apache license:
examples/qmf_agent.vcproj
- Added Apache license:
src/protocol_gen.mak
examples/qmf-agent/example_gen.mak
- Updated QMF Agent example README:
examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749571#action_12749571 ]
Andrew Stitcher commented on QPID-1918:
---------------------------------------
cpp/include/qpid/sys/windows/uuid.h /
cpp/src/qpid/sys/windows/uuid.cpp:
This change makes no sens to me: The qpid code doesn't need the includes in the header so it's in the implementation file.
How can including more in the header file be valid? If something else needs #include <rpc.h> then add it there.
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Andrew Stitcher
> Attachments: qpid-1918.patch
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733902#action_12733902 ]
Steve Huston commented on QPID-1918:
------------------------------------
The PipeHandle.cpp changes (simplified to always use TCP, never _pipe) were integrated in trunk r796577.
The ManagementAgentImpl.cpp change seems like it should maybe be handled more like the agent-not-initialized code in ManagementAgentImpl::ConnectionThread, but I didn't study this too closely... could you please check this out?
The uuid situation seems to have changed wrt includes... could you please re-evaluate your situation against trunk?
I'm a little uneasy about relying on Condor's autotools check for HAVE_... in IntegerTypes.h so I'm still thinking about this one. How does Condor get a size_t and pid_t type? Is it picking it up somewhere from Visual Studio, or defining them locally?
Re VS project file updates... I'm not devoting any more time to maintaining them. As soon as I have a little free time, I'm going to remove them all, so it's best to get the cmake stuff going. CMake will generate Visual Studio projects from which you can build, debug, etc. so it's just getting over the CMake step that's a hassle at first. I have a README in progress that explains it further and will try to get it check in soon.
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Steve Huston
> Attachments: qpid-1918.zip
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston reassigned QPID-1918:
----------------------------------
Assignee: Steve Huston
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Steve Huston
> Attachments: qpid-1918.zip
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749555#action_12749555 ]
Andrew Stitcher commented on QPID-1918:
---------------------------------------
git diff output isn't sufficient to feed to patch as it doesn't handle the renamed files correctly.
So qpid/cpp/examples/qmf-agent/sample.cpp qpid/cpp/examples/qmf-agent/sample_gen.mak aren't created by the patch.
Use git format-patch.
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Andrew Stitcher
> Attachments: qpid-1918.patch
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Pete MacKinnon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete MacKinnon updated QPID-1918:
---------------------------------
Attachment: 0001-Added-flags-for-optional-static-build-on-Windows.patch
Andrew,
Here is the CMake-specific patch we discussed a few weeks ago for enabling Windows static builds. I generated it today from trunk. Hopefully it is less contentious. :-)
qpid/cpp/src/CMakeLists.txt
qpid/cpp/examples/CMakeLists.txt
qpid/cpp/src/tests/CMakeLists.txt
\Pete
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Andrew Stitcher
> Attachments: 0001-Added-flags-for-optional-static-build-on-Windows.patch, qpid-1918.patch
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Pete MacKinnon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723085#action_12723085 ]
Pete MacKinnon commented on QPID-1918:
--------------------------------------
Steve, I gave the cmake build a try on Windows and didn't get very far. It seems like there is some environment set-up required to successfully build with VC++ 9.0. Do you have any instructions?
In the interim, would it be possible to just merge the vcproj patches for the time being in the interest of expediency. I'm happy to follow the cmake model going forward once I understand it better.
Thanks,
\Pete
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Steve Huston
> Attachments: qpid-1918.zip
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749575#action_12749575 ]
Andrew Stitcher commented on QPID-1918:
---------------------------------------
cpp/src/qpid/agent/ManagementAgentImpl.cpp:
Seeing as this is the only place that PipeHandle is used why the change in interface and in fact what's the external distinction all about?
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Andrew Stitcher
> Attachments: qpid-1918.patch
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750161#action_12750161 ]
Steve Huston commented on QPID-1918:
------------------------------------
Re pid_t and ssize_t...
They're used in APIs internal to Qpid (I don't think they're used externally but may be wrong)...
pid_t is used for recording and looking up the broker pid - DWORD is a good choice and could possibly resolve the issue around that typedef.
The HAVE_... macros introduced by the proposed patch come in from Condor (as I understand it) and is one reason I didn't want to include it.
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Andrew Stitcher
> Attachments: qpid-1918.patch
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Pete MacKinnon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734116#action_12734116 ]
Pete MacKinnon commented on QPID-1918:
--------------------------------------
Hi Steve,
I will provide a future patch that will alllow for PipeHandle to have a local _pipe as well as the select-friendly Socket approach.
I will revisit the ManagementAgentImpl.cpp code based on your suggestion but there seems to be non-deterministic behavior between the connection and publish logic which can sleep the publish thread for an inadvertently long time.
The uuid changes are actually more a less a revert to a previous version in Qpid. It was the only way I could surmount some significant code-level integration issues. I guess I could revisit this by trying to mitigate on the Condor side but am not optimistic.
The HAVE_ flags for pid_t and ssize_t are artificial and would not currently fall out of the Condor autotools step. They are specifically there for code-level integration between Qpid and Condor. I raised https://issues.apache.org/jira/browse/QPID-1951 to suggest we bury those Posix decls in the portability layer to avoid this hack.
I have been working on the Cmake changes I need and I think it looks pretty good. Once I have fixed some of the qmf-agent example QMF generation steps, I'll submit.
In summary, I will attach an updated patch zip (hopefully soon).
\Pete
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Steve Huston
> Attachments: qpid-1918.zip
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Pete MacKinnon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete MacKinnon updated QPID-1918:
---------------------------------
Attachment: qpid-1918.patch
Round 3. Replacing tar file with a single unified git diff file.
$ git diff -M --name-only HEAD
qpid/cpp/examples/CMakeLists.txt
qpid/cpp/examples/README.txt
qpid/cpp/examples/qmf-agent/Makefile
qpid/cpp/examples/qmf-agent/sample.cpp
qpid/cpp/examples/qmf-agent/sample_gen.mak
qpid/cpp/include/qpid/sys/windows/IntegerTypes.h
qpid/cpp/include/qpid/sys/windows/uuid.h
qpid/cpp/src/CMakeLists.txt
qpid/cpp/src/qpid/agent/ManagementAgentImpl.cpp
qpid/cpp/src/qpid/sys/windows/PipeHandle.cpp
qpid/cpp/src/qpid/sys/windows/uuid.cpp
qpid/cpp/src/tests/CMakeLists.txt
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Steve Huston
> Attachments: qpid-1918.patch
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Pete MacKinnon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete MacKinnon updated QPID-1918:
---------------------------------
Attachment: qpid-1918.zip
Windows patch zip
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Attachments: qpid-1918.zip
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Pete MacKinnon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete MacKinnon updated QPID-1918:
---------------------------------
Attachment: (was: qpid-1918.cmake.tar)
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Steve Huston
> Attachments: qpid-1918.patch
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722044#action_12722044 ]
Steve Huston commented on QPID-1918:
------------------------------------
I will integrate the code items here. The vcproj and nmake files won't be integrated since we're moving everything to CMake and will remove the vcproj files soon. (Linux is also going to CMake - not just Windows).
Could I ask you, Pete, to please begin to build your cases with the CMake stuff and help to work out anything you find that needs fixing or extending there?
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Steve Huston
> Attachments: qpid-1918.zip
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749570#action_12749570 ]
Andrew Stitcher commented on QPID-1918:
---------------------------------------
cpp/include/qpid/sys/windows/IntegerTypes.h:
It's not clear to me why se need either pid_t or ssize_t in here at all,
pid_t - I'm not sure that any code that uses pid_t is going to port well to windows, but the definition there should be DWORD (that's what GetCurrentProcessId() returns).
I'm confused by the use of the HAVE_xxx macros here,we're already in Windows specific code are there some circumstances where pid_t or ssize_t might be defined under windows?
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Andrew Stitcher
> Attachments: qpid-1918.patch
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749573#action_12749573 ]
Andrew Stitcher commented on QPID-1918:
---------------------------------------
cpp/src/CMakeLists.txt:
[Ignoring the spurious looking changes at the top]
There is endless repetition of the following pattern:
if (QPID_WINDOWS_STATIC)
add_library (qpidcommon STATIC ${libqpidcommon_SOURCES})
else ()
add_library (qpidcommon SHARED ${libqpidcommon_SOURCES})
endif (QPID_WINDOWS_STATIC)
Instead of doing this everywhere change it so that you define LIBRARY_LINKAGE to be STATIC or SHARED or somesuch at the top of the file just once and then do:
add_library(qpidcommon ${LIBRARY_LINKAGE} ${libqpidcommon_SOURCES})
[Avoiding duplication is not restricted to actual code]
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Andrew Stitcher
> Attachments: qpid-1918.patch
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749578#action_12749578 ]
Andrew Stitcher commented on QPID-1918:
---------------------------------------
cpp/src/qpid/sys/windows/PipeHandle.cpp:
I don't understand most of what's going on here, but the code has a very bad error in it twice:
bool createTcpPipe(bool overlapped, int writeFd, int readFd) {
...
writeFd = pair[0];
readFd = pair[1];
...
}
&
bool createCrtPipe(int writeFd, int readFd) {
int pair[2];
...
writeFd = pair[0];
readFd = pair[1];
...
}
[the code seems to assume that the fds are really passed by reference and so can be usefully assigned]
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Andrew Stitcher
> Attachments: qpid-1918.patch
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Stitcher reassigned QPID-1918:
-------------------------------------
Assignee: Andrew Stitcher (was: Steve Huston)
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Andrew Stitcher
> Attachments: qpid-1918.patch
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Pete MacKinnon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722672#action_12722672 ]
Pete MacKinnon commented on QPID-1918:
--------------------------------------
I'm a little behind on the whole Cmake stuff but from what I understand it can generate the vcproj files, is that right? It seems to me that Windows developers would still want to be able to work inside the IDE for debugging.
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Steve Huston
> Attachments: qpid-1918.zip
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Pete MacKinnon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete MacKinnon updated QPID-1918:
---------------------------------
Attachment: (was: qpid-1918.patch)
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Andrew Stitcher
> Attachments: 0001-Added-flags-for-optional-static-build-on-Windows.patch
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Pete MacKinnon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete MacKinnon updated QPID-1918:
---------------------------------
Attachment: qpid-1918.cmake.tar
Hi Steve,
OK Round 2. The attached tar file has the requested Cmake changes and the other patches are fixes needed for Condor/Grid integration. The CMake changes are for a static build (release and debug) on Windows and are optional. They are turned off by default and should be non-intrusive to a standard Qpid Windows build. I also need the qmf-agent file name example.cpp moved to sample.cpp since the very name "example" messes up in the Cmake build.
Please contact me by email if you have any questions.
PATCH:
qpid/cpp/src/CMakeLists.txt
qpid/cpp/src/tests/CMakeLists.txt
qpid/cpp/examples/CMakeLists.txt
qpid/cpp/examples/qmf-agent/Makefile
qpid/cpp/examples/README.txt
qpid/cpp/src/qpid/agent/ManagementAgentImpl.cpp
qpid/cpp/include/qpid/sys/windows/IntegerTypes.h
qpid/cpp/include/qpid/sys/windows/uuid.h
qpid/cpp/src/qpid/sys/windows/uuid.cpp
qpid/cpp/src/qpid/sys/windows/PipeHandle.cpp
ADD:
qpid/cpp/examples/qmf-agent/CMakeLists.txt
MOVE:
qpid/cpp/examples/qmf-agent/example_gen.mak -> qpid/cpp/examples/qmf-agent/sample_gen.mak
qpid/cpp/examples/qmf-agent/example.cpp -> qpid/cpp/examples/qmf-agent/sample.cpp
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Steve Huston
> Attachments: qpid-1918.cmake.tar
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Pete MacKinnon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete MacKinnon updated QPID-1918:
---------------------------------
Attachment: (was: qpid-1918.zip)
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Steve Huston
> Attachments: qpid-1918.cmake.tar
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Closed: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Pete MacKinnon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete MacKinnon closed QPID-1918.
--------------------------------
Resolution: Duplicate
Decomposed into separate Jiras: QPID-1951, QPID-2259 and possibly more
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Andrew Stitcher
> Attachments: 0001-Added-flags-for-optional-static-build-on-Windows.patch
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in
support
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749554#action_12749554 ]
Andrew Stitcher commented on QPID-1918:
---------------------------------------
The attached patch contains multiple changes; please split up the patch into multiple self contianed patches, one for each change. That way we can look at smaller lumps of code and hopefully commit the chnages incrementally.
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Andrew Stitcher
> Attachments: qpid-1918.patch
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org