You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/04/09 03:52:03 UTC
[GitHub] [iotdb] MarcosZyk opened a new pull request, #5465: Refactor schema region management
MarcosZyk opened a new pull request, #5465:
URL: https://github.com/apache/iotdb/pull/5465
## Description
SchemaEngine take on all the responsibility of schema region management. Now the localConfigManager only manage the schemaRegionId rather than manage schemaReigon directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk closed pull request #5465: Refactor schema region management and Improve DeleteStorageGroup procedure
Posted by GitBox <gi...@apache.org>.
MarcosZyk closed pull request #5465: Refactor schema region management and Improve DeleteStorageGroup procedure
URL: https://github.com/apache/iotdb/pull/5465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] cigarl commented on a diff in pull request #5465: Refactor schema region management and Improve DeleteStorageGroup procedure
Posted by GitBox <gi...@apache.org>.
cigarl commented on code in PR #5465:
URL: https://github.com/apache/iotdb/pull/5465#discussion_r846924543
##########
server/src/main/java/org/apache/iotdb/db/metadata/LocalConfigManager.java:
##########
@@ -289,6 +261,49 @@ private void ensureStorageGroup(PartialPath path, boolean shouldAllocateSchemaRe
}
}
+ /**
+ * Delete storage groups of given paths from MTree.
+ *
+ * @param storageGroups list of paths to be deleted.
+ */
+ public void deleteStorageGroups(List<PartialPath> storageGroups) throws MetadataException {
+ for (PartialPath storageGroup : storageGroups) {
+ deleteStorageGroup(storageGroup);
+ }
+ }
+
+ private void deleteStorageGroup(PartialPath storageGroup) throws MetadataException {
+ deleteSchemaRegionsInStorageGroup(
Review Comment:
If a `storageGroup` has five `schemaRegions` and failed to delete the third one（differences in distributed scenarios or multiple data path）, does the user still think the `storage group` is available（because the deletion failed）?
Maybe we need to fix consistency instead of just fixing a corner case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] cigarl commented on a diff in pull request #5465: Refactor schema region management and Improve DeleteStorageGroup procedure
Posted by GitBox <gi...@apache.org>.
cigarl commented on code in PR #5465:
URL: https://github.com/apache/iotdb/pull/5465#discussion_r846924543
##########
server/src/main/java/org/apache/iotdb/db/metadata/LocalConfigManager.java:
##########
@@ -289,6 +261,49 @@ private void ensureStorageGroup(PartialPath path, boolean shouldAllocateSchemaRe
}
}
+ /**
+ * Delete storage groups of given paths from MTree.
+ *
+ * @param storageGroups list of paths to be deleted.
+ */
+ public void deleteStorageGroups(List<PartialPath> storageGroups) throws MetadataException {
+ for (PartialPath storageGroup : storageGroups) {
+ deleteStorageGroup(storageGroup);
+ }
+ }
+
+ private void deleteStorageGroup(PartialPath storageGroup) throws MetadataException {
+ deleteSchemaRegionsInStorageGroup(
Review Comment:
If a `storageGroup` has five `schemaRegions` and failed to delete the third one（In distributed scenarios, the health status of different nodes may be inconsistent, such as disks）, does the user still think the `storage group` is available（because the deletion failed）?
Maybe we need to fix consistency instead of just fixing a corner case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org