You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2023/01/04 16:03:33 UTC

[GitHub] [iotdb] BUAAserein commented on a diff in pull request #8754: [IOTDB-5284] Fix some code smells

BUAAserein commented on code in PR #8754:
URL: https://github.com/apache/iotdb/pull/8754#discussion_r1061640622


##########
server/src/main/java/org/apache/iotdb/db/query/control/FileReaderManager.java:
##########
@@ -246,7 +246,7 @@ public synchronized boolean contains(TsFileResource tsFile, boolean isClosed) {
   public synchronized void writeFileReferenceInfo() {
     DEBUG_LOGGER.info("[closedReferenceMap]\n");
     for (Map.Entry<String, AtomicInteger> entry : closedReferenceMap.entrySet()) {
-      DEBUG_LOGGER.info(String.format("\t%s: %d\n", entry.getKey(), entry.getValue().get()));
+      DEBUG_LOGGER.info(String.format("\t%s: %d%n", entry.getKey(), entry.getValue().get()));

Review Comment:
   Please check https://rules.sonarsource.com/java/RSPEC-3457 and https://stackoverflow.com/questions/31981136/difference-between-n-and-n-for-printing-a-new-line-in-java



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org