[PR] [SPARK-56421] Introduce `IntervalType` protocol for `(DayTime|YearMonth)Interval` [spark-connect-swift]

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun opened a new pull request, #350:
URL: https://github.com/apache/spark-connect-swift/pull/350

   ### What changes were proposed in this pull request?
   
   This PR introduces an `IntervalType` protocol to deduplicate the identical `toString()` logic in `YearMonthInterval` and `DayTimeInterval` extensions in `Extension.swift`.
   
   ### Why are the changes needed?
   
   Both `YearMonthInterval` and `DayTimeInterval` had identical `toString()` implementations (differing only in `fieldToString` mappings), violating DRY principle. Extracting the shared logic into a protocol default implementation improves maintainability.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Pass the CIs.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 4.6)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56421] Introduce `IntervalType` protocol for `(DayTime|YearMonth)Interval` [spark-connect-swift]

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun closed pull request #350: [SPARK-56421] Introduce `IntervalType` protocol for `(DayTime|YearMonth)Interval`
URL: https://github.com/apache/spark-connect-swift/pull/350


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56421] Introduce `IntervalType` protocol for `(DayTime|YearMonth)Interval` [spark-connect-swift]

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on PR #350:
URL: https://github.com/apache/spark-connect-swift/pull/350#issuecomment-4216560366

   Thank you, @viirya .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56421] Introduce `IntervalType` protocol for `(DayTime|YearMonth)Interval` [spark-connect-swift]

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on PR #350:
URL: https://github.com/apache/spark-connect-swift/pull/350#issuecomment-4216563533

   Merged to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org