You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Volodymyr Moshkovskyi via Review Board <no...@reviews.apache.org> on 2020/03/11 10:59:27 UTC

Re: Review Request 72186: RANGER-2748 Ranger plugin for schema registry

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72186/
-----------------------------------------------------------

(Updated March 11, 2020, 10:59 a.m.)


Review request for ranger, Ramesh Mani and Saravanan Raju.


Summary (updated)
-----------------

RANGER-2748 Ranger plugin for schema registry


Repository: ranger


Description
-------

Ranger plugin for schema registry


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 882ca2f 
  agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json PRE-CREATION 
  plugin-schema-registry/pom.xml PRE-CREATION 
  plugin-schema-registry/src/main/assembly/binary.xml PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/RangerServiceSchemaRegistry.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgent.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgr.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/Client.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/SRClient.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtils.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgentTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgrTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/SRClientTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtilsTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/AcceptAllHostnameVerifier.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/DefaultClientForTesting.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/TestAutocompletionAgent.java PRE-CREATION 
  plugin-schema-registry/src/test/resources/keystore.jks PRE-CREATION 
  plugin-schema-registry/src/test/resources/schema-text3.avcs PRE-CREATION 
  plugin-schema-registry/src/test/resources/ssl-schema-registry-client.yaml PRE-CREATION 
  plugin-schema-registry/src/test/resources/ssl-schema-registry.yaml PRE-CREATION 
  plugin-schema-registry/src/test/resources/truststore.jks PRE-CREATION 
  pom.xml dde449d 


Diff: https://reviews.apache.org/r/72186/diff/1/


Testing
-------


Thanks,

Volodymyr Moshkovskyi


Re: Review Request 72186: RANGER-2748 Ranger plugin for schema registry

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72186/#review219905
-----------------------------------------------------------




plugin-schema-registry/pom.xml
Lines 40 (patched)
<https://reviews.apache.org/r/72186/#comment308143>

    This throws an error. Can you please address that as well? 
    
    ```
    [ERROR] Failed to execute goal on project ranger-schema-registry-plugin: Could not resolve dependencies for project org.apache.ranger:ranger-schema-registry-plugin:jar:2.1.0-SNAPSHOT: The following artifacts could not be resolved: com.hortonworks.registries:common-auth:jar:0.8.1-SNAPSHOT, com.hortonworks.registries:schema-registry-client:jar:0.8.1-SNAPSHOT, com.hortonworks.registries:schema-registry-webservice:jar:0.8.1-SNAPSHOT: Could not find artifact com.hortonworks.registries:common-auth:jar:0.8.1-SNAPSHOT in apache.snapshots.https (https://repository.apache.org/content/repositories/snapshots) -> [Help 1]
    [ERROR]
    ```


- Velmurugan Periasamy


On March 11, 2020, 8:57 p.m., Volodymyr Moshkovskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72186/
> -----------------------------------------------------------
> 
> (Updated March 11, 2020, 8:57 p.m.)
> 
> 
> Review request for ranger, Ramesh Mani and Saravanan Raju.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger plugin for schema registry
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 882ca2f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json PRE-CREATION 
>   plugin-schema-registry/pom.xml PRE-CREATION 
>   plugin-schema-registry/src/main/assembly/binary.xml PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/RangerServiceSchemaRegistry.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgr.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/ISchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtils.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgentTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgrTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClientTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtilsTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/AcceptAllHostnameVerifier.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/DefaultSchemaRegistryClientForTesting.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/TestAutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/test/resources/keystore.jks PRE-CREATION 
>   plugin-schema-registry/src/test/resources/schema-text3.avcs PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry-client.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/truststore.jks PRE-CREATION 
>   pom.xml dde449d 
> 
> 
> Diff: https://reviews.apache.org/r/72186/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Volodymyr Moshkovskyi
> 
>


Re: Review Request 72186: RANGER-2748 Ranger plugin for schema registry

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72186/#review219904
-----------------------------------------------------------




plugin-schema-registry/pom.xml
Lines 30 (patched)
<https://reviews.apache.org/r/72186/#comment308142>

    this should be 2.1.0-SNAPSHOT


- Ramesh Mani


On March 11, 2020, 8:57 p.m., Volodymyr Moshkovskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72186/
> -----------------------------------------------------------
> 
> (Updated March 11, 2020, 8:57 p.m.)
> 
> 
> Review request for ranger, Ramesh Mani and Saravanan Raju.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger plugin for schema registry
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 882ca2f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json PRE-CREATION 
>   plugin-schema-registry/pom.xml PRE-CREATION 
>   plugin-schema-registry/src/main/assembly/binary.xml PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/RangerServiceSchemaRegistry.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgr.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/ISchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtils.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgentTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgrTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClientTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtilsTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/AcceptAllHostnameVerifier.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/DefaultSchemaRegistryClientForTesting.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/TestAutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/test/resources/keystore.jks PRE-CREATION 
>   plugin-schema-registry/src/test/resources/schema-text3.avcs PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry-client.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/truststore.jks PRE-CREATION 
>   pom.xml dde449d 
> 
> 
> Diff: https://reviews.apache.org/r/72186/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Volodymyr Moshkovskyi
> 
>


Re: Review Request 72186: RANGER-2748 Ranger plugin for schema registry

Posted by Saravanan Raju <sa...@gmail.com>.

> On March 11, 2020, 10:31 p.m., Ramesh Mani wrote:
> > plugin-schema-registry/pom.xml
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/72186/diff/2/?file=2213443#file2213443line30>
> >
> >     Getting this error. Please check  schema-registry.version 0.8.1-SNAPSHOT is there in the repo
> >     [INFO] ------------------------------------------------------------------------
> >     [ERROR] Failed to execute goal on project ranger-schema-registry-plugin: Could not resolve dependencies for project org.apache.ranger:ranger-schema-registry-plugin:jar:2.1.0-SNAPSHOT: The following artifacts could not be resolved: com.hortonworks.registries:common-auth:jar:0.8.1-SNAPSHOT, com.hortonworks.registries:schema-registry-client:jar:0.8.1-SNAPSHOT, com.hortonworks.registries:schema-registry-webservice:jar:0.8.1-SNAPSHOT: Could not find artifact com.hortonworks.registries:common-auth:jar:0.8.1-SNAPSHOT in apache.snapshots.https (https://repository.apache.org/content/repositories/snapshots) -> [Help 1]

This issue has been resolved in the latest commit, @rmani can you have another look ?


- Saravanan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72186/#review219906
-----------------------------------------------------------


On March 13, 2020, 2:03 p.m., Volodymyr Moshkovskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72186/
> -----------------------------------------------------------
> 
> (Updated March 13, 2020, 2:03 p.m.)
> 
> 
> Review request for ranger, Ramesh Mani and Saravanan Raju.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger plugin for schema registry
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 882ca2f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json PRE-CREATION 
>   plugin-schema-registry/pom.xml PRE-CREATION 
>   plugin-schema-registry/src/main/assembly/binary.xml PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/RangerServiceSchemaRegistry.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgr.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/ISchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtils.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgentTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgrTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClientTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtilsTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/AcceptAllHostnameVerifier.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/DefaultSchemaRegistryClientForTesting.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/TestAutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/test/resources/keystore.jks PRE-CREATION 
>   plugin-schema-registry/src/test/resources/schema-text3.avcs PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry-client.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/truststore.jks PRE-CREATION 
>   pom.xml dde449d 
> 
> 
> Diff: https://reviews.apache.org/r/72186/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Volodymyr Moshkovskyi
> 
>


Re: Review Request 72186: RANGER-2748 Ranger plugin for schema registry

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72186/#review219906
-----------------------------------------------------------




plugin-schema-registry/pom.xml
Lines 30 (patched)
<https://reviews.apache.org/r/72186/#comment308144>

    Getting this error. Please check  schema-registry.version 0.8.1-SNAPSHOT is there in the repo
    [INFO] ------------------------------------------------------------------------
    [ERROR] Failed to execute goal on project ranger-schema-registry-plugin: Could not resolve dependencies for project org.apache.ranger:ranger-schema-registry-plugin:jar:2.1.0-SNAPSHOT: The following artifacts could not be resolved: com.hortonworks.registries:common-auth:jar:0.8.1-SNAPSHOT, com.hortonworks.registries:schema-registry-client:jar:0.8.1-SNAPSHOT, com.hortonworks.registries:schema-registry-webservice:jar:0.8.1-SNAPSHOT: Could not find artifact com.hortonworks.registries:common-auth:jar:0.8.1-SNAPSHOT in apache.snapshots.https (https://repository.apache.org/content/repositories/snapshots) -> [Help 1]


- Ramesh Mani


On March 11, 2020, 8:57 p.m., Volodymyr Moshkovskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72186/
> -----------------------------------------------------------
> 
> (Updated March 11, 2020, 8:57 p.m.)
> 
> 
> Review request for ranger, Ramesh Mani and Saravanan Raju.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger plugin for schema registry
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 882ca2f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json PRE-CREATION 
>   plugin-schema-registry/pom.xml PRE-CREATION 
>   plugin-schema-registry/src/main/assembly/binary.xml PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/RangerServiceSchemaRegistry.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgr.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/ISchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtils.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgentTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgrTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClientTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtilsTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/AcceptAllHostnameVerifier.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/DefaultSchemaRegistryClientForTesting.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/TestAutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/test/resources/keystore.jks PRE-CREATION 
>   plugin-schema-registry/src/test/resources/schema-text3.avcs PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry-client.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/truststore.jks PRE-CREATION 
>   pom.xml dde449d 
> 
> 
> Diff: https://reviews.apache.org/r/72186/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Volodymyr Moshkovskyi
> 
>


Re: Review Request 72186: RANGER-2748 Ranger plugin for schema registry

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72186/#review219901
-----------------------------------------------------------



updated service-def looks good!

- Madhan Neethiraj


On March 11, 2020, 8:57 p.m., Volodymyr Moshkovskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72186/
> -----------------------------------------------------------
> 
> (Updated March 11, 2020, 8:57 p.m.)
> 
> 
> Review request for ranger, Ramesh Mani and Saravanan Raju.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger plugin for schema registry
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 882ca2f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json PRE-CREATION 
>   plugin-schema-registry/pom.xml PRE-CREATION 
>   plugin-schema-registry/src/main/assembly/binary.xml PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/RangerServiceSchemaRegistry.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgr.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/ISchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtils.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgentTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgrTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClientTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtilsTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/AcceptAllHostnameVerifier.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/DefaultSchemaRegistryClientForTesting.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/TestAutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/test/resources/keystore.jks PRE-CREATION 
>   plugin-schema-registry/src/test/resources/schema-text3.avcs PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry-client.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/truststore.jks PRE-CREATION 
>   pom.xml dde449d 
> 
> 
> Diff: https://reviews.apache.org/r/72186/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Volodymyr Moshkovskyi
> 
>


Re: Review Request 72186: RANGER-2748 Ranger plugin for schema registry

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72186/#review219973
-----------------------------------------------------------


Fix it, then Ship it!





plugin-schema-registry/src/main/assembly/binary.xml
Lines 16 (patched)
<https://reviews.apache.org/r/72186/#comment308206>

    Assembly descriptors for all modules are under distro directory. This file should be moved there as well; this can be taken up in a subsequent patch.


- Madhan Neethiraj


On March 13, 2020, 2:03 p.m., Volodymyr Moshkovskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72186/
> -----------------------------------------------------------
> 
> (Updated March 13, 2020, 2:03 p.m.)
> 
> 
> Review request for ranger, Ramesh Mani and Saravanan Raju.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger plugin for schema registry
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 882ca2f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json PRE-CREATION 
>   plugin-schema-registry/pom.xml PRE-CREATION 
>   plugin-schema-registry/src/main/assembly/binary.xml PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/RangerServiceSchemaRegistry.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgr.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/ISchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtils.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgentTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgrTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClientTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtilsTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/AcceptAllHostnameVerifier.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/DefaultSchemaRegistryClientForTesting.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/TestAutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/test/resources/keystore.jks PRE-CREATION 
>   plugin-schema-registry/src/test/resources/schema-text3.avcs PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry-client.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/truststore.jks PRE-CREATION 
>   pom.xml dde449d 
> 
> 
> Diff: https://reviews.apache.org/r/72186/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Volodymyr Moshkovskyi
> 
>


Re: Review Request 72186: RANGER-2748 Ranger plugin for schema registry

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72186/#review219971
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On March 13, 2020, 2:03 p.m., Volodymyr Moshkovskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72186/
> -----------------------------------------------------------
> 
> (Updated March 13, 2020, 2:03 p.m.)
> 
> 
> Review request for ranger, Ramesh Mani and Saravanan Raju.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger plugin for schema registry
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 882ca2f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json PRE-CREATION 
>   plugin-schema-registry/pom.xml PRE-CREATION 
>   plugin-schema-registry/src/main/assembly/binary.xml PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/RangerServiceSchemaRegistry.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgr.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/ISchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtils.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgentTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgrTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClientTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtilsTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/AcceptAllHostnameVerifier.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/DefaultSchemaRegistryClientForTesting.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/TestAutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/test/resources/keystore.jks PRE-CREATION 
>   plugin-schema-registry/src/test/resources/schema-text3.avcs PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry-client.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/truststore.jks PRE-CREATION 
>   pom.xml dde449d 
> 
> 
> Diff: https://reviews.apache.org/r/72186/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Volodymyr Moshkovskyi
> 
>


Re: Review Request 72186: RANGER-2748 Ranger plugin for schema registry

Posted by Volodymyr Moshkovskyi via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72186/
-----------------------------------------------------------

(Updated March 13, 2020, 2:03 p.m.)


Review request for ranger, Ramesh Mani and Saravanan Raju.


Repository: ranger


Description
-------

Ranger plugin for schema registry


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 882ca2f 
  agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json PRE-CREATION 
  plugin-schema-registry/pom.xml PRE-CREATION 
  plugin-schema-registry/src/main/assembly/binary.xml PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/RangerServiceSchemaRegistry.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgent.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgr.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClient.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/ISchemaRegistryClient.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtils.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgentTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgrTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClientTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtilsTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/AcceptAllHostnameVerifier.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/DefaultSchemaRegistryClientForTesting.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/TestAutocompletionAgent.java PRE-CREATION 
  plugin-schema-registry/src/test/resources/keystore.jks PRE-CREATION 
  plugin-schema-registry/src/test/resources/schema-text3.avcs PRE-CREATION 
  plugin-schema-registry/src/test/resources/ssl-schema-registry-client.yaml PRE-CREATION 
  plugin-schema-registry/src/test/resources/ssl-schema-registry.yaml PRE-CREATION 
  plugin-schema-registry/src/test/resources/truststore.jks PRE-CREATION 
  pom.xml dde449d 


Diff: https://reviews.apache.org/r/72186/diff/4/

Changes: https://reviews.apache.org/r/72186/diff/3-4/


Testing
-------


Thanks,

Volodymyr Moshkovskyi


Re: Review Request 72186: RANGER-2748 Ranger plugin for schema registry

Posted by Saravanan Raju <sa...@gmail.com>.

> On March 12, 2020, 4:43 a.m., Pradeep Agrawal wrote:
> > Can you add more details about this feature. if possible add a cwiki doc.

Is it ok if we can add the doc after the PR gets merged. We are pressed for time.


- Saravanan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72186/#review219911
-----------------------------------------------------------


On March 13, 2020, 2:03 p.m., Volodymyr Moshkovskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72186/
> -----------------------------------------------------------
> 
> (Updated March 13, 2020, 2:03 p.m.)
> 
> 
> Review request for ranger, Ramesh Mani and Saravanan Raju.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger plugin for schema registry
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 882ca2f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json PRE-CREATION 
>   plugin-schema-registry/pom.xml PRE-CREATION 
>   plugin-schema-registry/src/main/assembly/binary.xml PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/RangerServiceSchemaRegistry.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgr.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/ISchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtils.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgentTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgrTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClientTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtilsTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/AcceptAllHostnameVerifier.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/DefaultSchemaRegistryClientForTesting.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/TestAutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/test/resources/keystore.jks PRE-CREATION 
>   plugin-schema-registry/src/test/resources/schema-text3.avcs PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry-client.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/truststore.jks PRE-CREATION 
>   pom.xml dde449d 
> 
> 
> Diff: https://reviews.apache.org/r/72186/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Volodymyr Moshkovskyi
> 
>


Re: Review Request 72186: RANGER-2748 Ranger plugin for schema registry

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72186/#review219911
-----------------------------------------------------------



Can you add more details about this feature. if possible add a cwiki doc.

- Pradeep Agrawal


On 三月 12, 2020, 午夜, Volodymyr Moshkovskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72186/
> -----------------------------------------------------------
> 
> (Updated 三月 12, 2020, 午夜)
> 
> 
> Review request for ranger, Ramesh Mani and Saravanan Raju.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger plugin for schema registry
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 882ca2f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json PRE-CREATION 
>   plugin-schema-registry/pom.xml PRE-CREATION 
>   plugin-schema-registry/src/main/assembly/binary.xml PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/RangerServiceSchemaRegistry.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgr.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/ISchemaRegistryClient.java PRE-CREATION 
>   plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtils.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgentTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgrTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClientTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtilsTest.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/AcceptAllHostnameVerifier.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/DefaultSchemaRegistryClientForTesting.java PRE-CREATION 
>   plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/TestAutocompletionAgent.java PRE-CREATION 
>   plugin-schema-registry/src/test/resources/keystore.jks PRE-CREATION 
>   plugin-schema-registry/src/test/resources/schema-text3.avcs PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry-client.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/ssl-schema-registry.yaml PRE-CREATION 
>   plugin-schema-registry/src/test/resources/truststore.jks PRE-CREATION 
>   pom.xml dde449d 
> 
> 
> Diff: https://reviews.apache.org/r/72186/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Volodymyr Moshkovskyi
> 
>


Re: Review Request 72186: RANGER-2748 Ranger plugin for schema registry

Posted by Volodymyr Moshkovskyi via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72186/
-----------------------------------------------------------

(Updated March 12, 2020, midnight)


Review request for ranger, Ramesh Mani and Saravanan Raju.


Repository: ranger


Description
-------

Ranger plugin for schema registry


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 882ca2f 
  agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json PRE-CREATION 
  plugin-schema-registry/pom.xml PRE-CREATION 
  plugin-schema-registry/src/main/assembly/binary.xml PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/RangerServiceSchemaRegistry.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgent.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgr.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClient.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/ISchemaRegistryClient.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtils.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgentTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgrTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClientTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtilsTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/AcceptAllHostnameVerifier.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/DefaultSchemaRegistryClientForTesting.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/TestAutocompletionAgent.java PRE-CREATION 
  plugin-schema-registry/src/test/resources/keystore.jks PRE-CREATION 
  plugin-schema-registry/src/test/resources/schema-text3.avcs PRE-CREATION 
  plugin-schema-registry/src/test/resources/ssl-schema-registry-client.yaml PRE-CREATION 
  plugin-schema-registry/src/test/resources/ssl-schema-registry.yaml PRE-CREATION 
  plugin-schema-registry/src/test/resources/truststore.jks PRE-CREATION 
  pom.xml dde449d 


Diff: https://reviews.apache.org/r/72186/diff/3/

Changes: https://reviews.apache.org/r/72186/diff/2-3/


Testing
-------


Thanks,

Volodymyr Moshkovskyi


Re: Review Request 72186: RANGER-2748 Ranger plugin for schema registry

Posted by Volodymyr Moshkovskyi via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72186/
-----------------------------------------------------------

(Updated March 11, 2020, 8:57 p.m.)


Review request for ranger, Ramesh Mani and Saravanan Raju.


Repository: ranger


Description
-------

Ranger plugin for schema registry


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 882ca2f 
  agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json PRE-CREATION 
  plugin-schema-registry/pom.xml PRE-CREATION 
  plugin-schema-registry/src/main/assembly/binary.xml PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/RangerServiceSchemaRegistry.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgent.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgr.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClient.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/ISchemaRegistryClient.java PRE-CREATION 
  plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtils.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgentTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgrTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/DefaultSchemaRegistryClientTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtilsTest.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/AcceptAllHostnameVerifier.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/DefaultSchemaRegistryClientForTesting.java PRE-CREATION 
  plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/TestAutocompletionAgent.java PRE-CREATION 
  plugin-schema-registry/src/test/resources/keystore.jks PRE-CREATION 
  plugin-schema-registry/src/test/resources/schema-text3.avcs PRE-CREATION 
  plugin-schema-registry/src/test/resources/ssl-schema-registry-client.yaml PRE-CREATION 
  plugin-schema-registry/src/test/resources/ssl-schema-registry.yaml PRE-CREATION 
  plugin-schema-registry/src/test/resources/truststore.jks PRE-CREATION 
  pom.xml dde449d 


Diff: https://reviews.apache.org/r/72186/diff/2/

Changes: https://reviews.apache.org/r/72186/diff/1-2/


Testing
-------


Thanks,

Volodymyr Moshkovskyi