You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Yun Gao (Jira)" <ji...@apache.org> on 2022/04/08 06:49:00 UTC
[jira] [Commented] (FLINK-26190) Remove getTableConfig from ExecNodeConfiguration
[ https://issues.apache.org/jira/browse/FLINK-26190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519343#comment-17519343 ]
Yun Gao commented on FLINK-26190:
---------------------------------
[~dianfu] it seems the code could not be compiled now.
> Remove getTableConfig from ExecNodeConfiguration
> ------------------------------------------------
>
> Key: FLINK-26190
> URL: https://issues.apache.org/jira/browse/FLINK-26190
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
> Reporter: Marios Trivyzas
> Assignee: Dian Fu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> Currently, *ExecNodeConfig* holds *TableConfig* instead of *ReadableConfig* for the configuration coming from the planner, because it's used by
> *CommonPythonUtil#getMergedConfig.* This should be fixed, so that *CommonPythonUtil#getMergedConfig* cam use a *ReadableConfig* instead, and then we can pass the *ExecNodeConfig* which holds the complete view of {*}Planner{*}'s *TableConfig* + the {*}ExecNode{*}'s {*}persistedConfig{*}.
>
> To achieve that the *getMergedConfig* methods of *PythonConfigUtil* must be changed, and also the temp solution in
> *PythonFunctionFactory#getPythonFunction* must be changed as well:
> {noformat}
> if (config instanceof TableConfig) {
> PythonDependencyUtils.merge(mergedConfig, ((TableConfig) config).getConfiguration());
> } else {
> PythonDependencyUtils.merge(mergedConfig, (Configuration) config);
> }{noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)