You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@freestoneinfotech.com> on 2016/06/25 16:30:19 UTC
Review Request 49229: RANGER-1063 : Increase size of sort_order
column of x_policy_item_user_perm and x_policy_item_group_perm table
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49229/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1063
https://issues.apache.org/jira/browse/RANGER-1063
Repository: ranger
Description
-------
**Problem Statement :** Currently data type of sort_order column is tinyint which can accept maximum 128 unsigned number; if any policy item is having more than 128 users then data truncation error might get generated at DB end and application shall not be able to insert entry of user any more for specific policy item.
**Proposed Solution :** Change data type of sort_order column of 'x_policy_item_user_perm' and 'x_policy_item_group_perm' table from tinyint to integer(4 byte)
Diffs
-----
security-admin/db/mysql/patches/024-sortorder-column-size.sql PRE-CREATION
security-admin/db/oracle/patches/024-sortorder-column-size.sql PRE-CREATION
security-admin/db/postgres/patches/024-sortorder-column-size.sql PRE-CREATION
security-admin/db/sqlanywhere/patches/024-sortorder-column-size.sql PRE-CREATION
security-admin/db/sqlserver/patches/024-sortorder-column-size.sql PRE-CREATION
Diff: https://reviews.apache.org/r/49229/diff/
Testing
-------
**Steps Performed (with patch) :**
1. After mvn Build; untar the Ranger module and updated install.properties for MySQL DB flavor.
2. Called setup.sh to install Ranger.
**Expected Behavior :**
1. Ranger installation should finish successfully and patch 024 should get applied successfully.
2. Data type of sort_order column of x_policy_item_user_perm and x_policy_item_group_perm table should get change to 'int'
2. Ranger UI should work.
**Actual Behavior :**
1. Ranger Installtion finished successfully and patch 024 was applied successfully.
2. Data type of sort_order column of x_policy_item_user_perm and x_policy_item_group_perm table was changed to 'int'
2. Started Ranger Admin and was able to login in Ranger UI.
Note: Patch has been tested on all supported DB Flavors.
Thanks,
Pradeep Agrawal
Re: Review Request 49229: RANGER-1063 : Increase size of sort_order
column of x_policy_item_user_perm and x_policy_item_group_perm table
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49229/#review139799
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On June 25, 2016, 4:30 p.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49229/
> -----------------------------------------------------------
>
> (Updated June 25, 2016, 4:30 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1063
> https://issues.apache.org/jira/browse/RANGER-1063
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem Statement :** Currently data type of sort_order column is tinyint which can accept maximum 128 unsigned number; if any policy item is having more than 128 users then data truncation error might get generated at DB end and application shall not be able to insert entry of user any more for specific policy item.
>
> **Proposed Solution :** Change data type of sort_order column of 'x_policy_item_user_perm' and 'x_policy_item_group_perm' table from tinyint to integer(4 byte)
>
>
> Diffs
> -----
>
> security-admin/db/mysql/patches/024-sortorder-column-size.sql PRE-CREATION
> security-admin/db/oracle/patches/024-sortorder-column-size.sql PRE-CREATION
> security-admin/db/postgres/patches/024-sortorder-column-size.sql PRE-CREATION
> security-admin/db/sqlanywhere/patches/024-sortorder-column-size.sql PRE-CREATION
> security-admin/db/sqlserver/patches/024-sortorder-column-size.sql PRE-CREATION
>
> Diff: https://reviews.apache.org/r/49229/diff/
>
>
> Testing
> -------
>
> **Steps Performed (with patch) :**
> 1. After mvn Build; untar the Ranger module and updated install.properties for MySQL DB flavor.
> 2. Called setup.sh to install Ranger.
>
> **Expected Behavior :**
> 1. Ranger installation should finish successfully and patch 024 should get applied successfully.
> 2. Data type of sort_order column of x_policy_item_user_perm and x_policy_item_group_perm table should get change to 'int'
> 2. Ranger UI should work.
>
> **Actual Behavior :**
> 1. Ranger Installtion finished successfully and patch 024 was applied successfully.
> 2. Data type of sort_order column of x_policy_item_user_perm and x_policy_item_group_perm table was changed to 'int'
> 2. Started Ranger Admin and was able to login in Ranger UI.
>
> Note: Patch has been tested on all supported DB Flavors.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>