You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/11/29 18:33:58 UTC
[GitHub] [accumulo] dlmarion opened a new issue, #3095: Add GitHub build action that fails the build if Thrift generated code is different
dlmarion opened a new issue, #3095:
URL: https://github.com/apache/accumulo/issues/3095
Add a build step that uses Thrift to generate the java code and compare it to the code in core/src/main/thrift-gen-java/. If different, fail the build so that the PR owner can regenerate the Thrift java files and push them to their branch. This will require installing Thrift as part of the GitHub action. We should look to see if there is an ASF repository where we could host a Thrift binary tarball and then download it as part of the action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on issue #3095: Add GitHub build action that fails the build if Thrift generated code is different
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on issue #3095:
URL: https://github.com/apache/accumulo/issues/3095#issuecomment-1529614046
@ctubbsii - This is great, thanks for doing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #3095: Add GitHub build action that fails the build if Thrift generated code is different
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #3095:
URL: https://github.com/apache/accumulo/issues/3095#issuecomment-1331172174
It doesn't even need to be a binary tarball... just the single executable for `bin/thrift`. Actually, we can probably put it in svn. We have a dev space there we can use. We can also try to cache it in GitHub Actions so it doesn't need to be re-downloaded every time. The main concern is builds triggering IP bans on ASF infrastructure, so we need to be responsible in ensuring the downloads are aren't too frequent.
I can spend a little time looking into this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii closed issue #3095: Add GitHub build action that fails the build if Thrift generated code is different
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii closed issue #3095: Add GitHub build action that fails the build if Thrift generated code is different
URL: https://github.com/apache/accumulo/issues/3095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org