You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Reranko05 (via GitHub)" <gi...@apache.org> on 2026/09/14 19:08:47 UTC
[PR] GH-51311: [C++][Compute] Add float16 to FloatingPointTypes [arrow]
Reranko05 opened a new pull request, #51330:
URL: https://github.com/apache/arrow/pull/51330
### Rationale
`FloatingPointTypes()` currently contains only `float32()` and `float64()`, so `float16()` is also omitted from `NumericTypes()` and `PrimitiveTypes()`.
This was noted as a follow-up during the review of [#50513](https://github.com/apache/arrow/pull/50513#discussion_r3628522049).
### Changes
- Add `float16()` to `FloatingPointTypes()`.
- `NumericTypes()` and `PrimitiveTypes()` automatically include `float16()` through their existing composition from `FloatingPointTypes()`.
### Testing
- `arrow-type-test` passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51311: [C++][Compute] Add float16 to FloatingPointTypes [arrow]
Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #51330:
URL: https://github.com/apache/arrow/pull/51330#issuecomment-5670592719
Once #50513 is merged, we can verify that the updated type list works correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51311: [C++][Compute] Add float16 to FloatingPointTypes [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #51330: GH-51311: [C++][Compute] Add float16 to FloatingPointTypes
URL: https://github.com/apache/arrow/pull/51330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51311: [C++][Compute] Add float16 to FloatingPointTypes [arrow]
Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #51330:
URL: https://github.com/apache/arrow/pull/51330#issuecomment-5717906734
@pitrou Okay, so should I update the affected tests to avoid float16 for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51311: [C++][Compute] Add float16 to FloatingPointTypes [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51330:
URL: https://github.com/apache/arrow/pull/51330#issuecomment-5669259616
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
**This pull request has been automatically closed because you currently have 5 open pull requests, which is more than the limit of 3.**
Due to the increase in pull requests opened by AI bots, and in order to keep the review queue manageable, Apache Arrow limits contributors without write access to at most 3 concurrently open pull requests. This helps make sure each pull request gets the attention it needs and that work in progress does not go stale.
Once one of [your other open pull requests](https://github.com/apache/arrow/pulls/Reranko05) has been merged or closed, you are welcome to reopen this one.
See also:
* [Contribution Guidelines - Limit on concurrent pull requests](https://arrow.apache.org/docs/dev/developers/bug_reports.html#pr-limit)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51311: [C++][Compute] Add float16 to FloatingPointTypes [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #51330:
URL: https://github.com/apache/arrow/pull/51330#issuecomment-5717759569
@Reranko05 , as I expected, this is breaking a lot of existing tests for functionality that doesn't accept Float16 currently.
The easy way out is to avoid running those tests on Float16, but it would be nicer of course to progressively have all the tested functionality accept Float16.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51311: [C++][Compute] Add float16 to FloatingPointTypes [arrow]
Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #51330:
URL: https://github.com/apache/arrow/pull/51330#issuecomment-5720617735
@pitrou `NumericTypes()` gets `float16` indirectly through `g_floating_types`. Once `float16` is included, production registration paths iterating over `NumericTypes()` can pass `Type::HALF_FLOAT` to `ArithmeticExecFromOp()`, which currently only has cases for `FLOAT` and `DOUBLE` (float32/float64). So this needs to be handled separately from the test-only exclusions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51311: [C++][Compute] Add float16 to FloatingPointTypes [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51330:
URL: https://github.com/apache/arrow/pull/51330#issuecomment-5669258984
:warning: GitHub issue #51311 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51311: [C++][Compute] Add float16 to FloatingPointTypes [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #51330:
URL: https://github.com/apache/arrow/pull/51330#issuecomment-5718458392
Yes, probably. Perhaps using a test-only function that would return floating-point types without Float16.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org