You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/01/16 12:19:50 UTC

[GitHub] [couchdb] rnewson commented on a change in pull request #2450: More way to detect presence of hastings for Ken

rnewson commented on a change in pull request #2450: More way to detect presence of hastings for Ken
URL: https://github.com/apache/couchdb/pull/2450#discussion_r367387605
 
 

 ##########
 File path: src/ken/rebar.config.script
 ##########
 @@ -11,7 +11,12 @@
 % the License.
 
 HaveDreyfus = element(1, file:list_dir("../dreyfus")) == ok.
-HaveHastings = element(1, file:list_dir("../hastings")) == ok.
+
+HastingsHome = case os:getenv("HASTINGS_HOME") of
 
 Review comment:
   `HastingsHome = os:getenv("HASTINGS_HOME", "../hastings")` would be cleaner imo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services