You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2026/08/18 13:01:42 UTC
[PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
raulcd opened a new pull request, #50902:
URL: https://github.com/apache/arrow/pull/50902
## TBD:
Currently just testing.
### Rationale for this change
### What changes are included in this PR?
### Are these changes tested?
### Are there any user-facing changes?
**This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
**This PR contains a "Critical Fix".** (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50902:
URL: https://github.com/apache/arrow/pull/50902#issuecomment-5343751161
Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit f293a087439a8932263e8520aa54641d7c61936d.
There were 5 benchmark results indicating a performance regression:
- Pull Request Run on `amd64-c6a-4xlarge-linux` at [2026-08-19 09:35:52Z](https://conbench.arrow-dev.org/compare/runs/964c0e4e77d247c0a501e20e836c9f62...74135db4deea45538760ba07967545bf/)
- [`BM_UnpackUint64` (C++) with params=Sse42Unaligned/8/64, source=cpp-micro, suite=arrow-bpacking-benchmark](https://conbench.arrow-dev.org/compare/benchmarks/06a8393d346c718c8000378ada7762e4...06a8579ba04771858000ab7a86c70162)
- [`RecordBatchSortIndicesInt64Narrow` (C++) with params=1048576/100/1, source=cpp-micro, suite=arrow-compute-vector-sort-benchmark](https://conbench.arrow-dev.org/compare/benchmarks/06a83941821879ad800031552c582efa...06a8579f61dd7f4980004ff1aa17c521)
- and 3 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/96109763894) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50902:
URL: https://github.com/apache/arrow/pull/50902#issuecomment-5328585968
Revision: 0ea10af06123e2da67ad1be0b40411ba7377066a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-43e3957538](https://github.com/ursacomputing/crossbow/branches/all?query=actions-43e3957538)
|Task|Status|
|----|------|
|wheel-manylinux-2-28-cp314-cp314-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/32140459130/job/95721614917)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50902:
URL: https://github.com/apache/arrow/pull/50902#issuecomment-5328545039
@github-actions crossbow submit wheel-manylinux-2-28-cp314-cp314-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #50902:
URL: https://github.com/apache/arrow/pull/50902#issuecomment-5328930791
Benchmark runs are scheduled for commit d9d991d7f4b6d5a8205772c6c1a4a76a20c44e18. Watch https://buildkite.com/apache-arrow and https://conbench.arrow-dev.org for updates. A comment will be posted here when the runs are complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50902:
URL: https://github.com/apache/arrow/pull/50902#issuecomment-5328929697
@ursabot please benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50902:
URL: https://github.com/apache/arrow/pull/50902#issuecomment-5344827223
Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit 83d61b96495af802594fb7ec1386601cc32e4393.
There were 34 benchmark results indicating a performance regression:
- Pull Request Run on `arm64-t4g-2xlarge-linux` at [2026-08-19 12:00:30Z](https://conbench.arrow-dev.org/compare/runs/0714fabd67174a3aad4e8d5548838dd3...babb182e83ee4bbe82565473969d6d62/)
- [`ThreadPoolSpawn` (C++) with params=threads:2/task_cost:100000/real_time, source=cpp-micro, suite=arrow-thread-pool-benchmark](https://conbench.arrow-dev.org/compare/benchmarks/06a8397ca11471558000211ae56744dc...06a8598c942978048000a6eab33db58a)
- [`ThreadPoolSpawn` (C++) with params=threads:2/task_cost:100000/real_time, source=cpp-micro, suite=arrow-thread-pool-benchmark](https://conbench.arrow-dev.org/compare/benchmarks/06a8397ca11471558000211ae56744dc...06a85b47f42d7e038000a7b22e6a06be)
- and 32 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/96138491530) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50902:
URL: https://github.com/apache/arrow/pull/50902#issuecomment-5328904995
Revision: 0ea10af06123e2da67ad1be0b40411ba7377066a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5df70e9967](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5df70e9967)
|Task|Status|
|----|------|
|wheel-manylinux-2-28-cp314-cp314-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/32142812506/job/95729301096)|
|wheel-manylinux-2-28-cp314-cp314-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/32142812460/job/95729300653)|
|wheel-manylinux-2-28-cp314-cp314t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/32142811863/job/95729299139)|
|wheel-manylinux-2-28-cp314-cp314t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/32142813137/job/95729303267)|
|wheel-musllinux-1-2-cp314-cp314-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/32142813278/job/95729303614)|
|wheel-musllinux-1-2-cp314-cp314-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/32142812560/job/95729302641)|
|wheel-musllinux-1-2-cp314-cp314t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/32142811052/job/95729296169)|
|wheel-musllinux-1-2-cp314-cp314t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/32142812145/job/95729299784)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50902:
URL: https://github.com/apache/arrow/pull/50902#issuecomment-5328845840
@github-actions crossbow submit wheel-*linux-*-cp314-cp314*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #50902:
URL: https://github.com/apache/arrow/pull/50902#issuecomment-5339497513
Benchmark runs are scheduled for commit f293a087439a8932263e8520aa54641d7c61936d. Watch https://buildkite.com/apache-arrow and https://conbench.arrow-dev.org for updates. A comment will be posted here when the runs are complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #50902:
URL: https://github.com/apache/arrow/pull/50902#issuecomment-5340335436
Benchmark runs are scheduled for commit 83d61b96495af802594fb7ec1386601cc32e4393. Watch https://buildkite.com/apache-arrow and https://conbench.arrow-dev.org for updates. A comment will be posted here when the runs are complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50902:
URL: https://github.com/apache/arrow/pull/50902#issuecomment-5340334509
@ursabot please benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50902:
URL: https://github.com/apache/arrow/pull/50902#issuecomment-5339496726
@ursabot please benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50902:
URL: https://github.com/apache/arrow/pull/50902#issuecomment-5328549599
:warning: GitHub issue #39026 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39026: [C++][Python] Add ARROW_HARDENING compiler options [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50902:
URL: https://github.com/apache/arrow/pull/50902#issuecomment-5333349620
Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit d9d991d7f4b6d5a8205772c6c1a4a76a20c44e18.
There were 87 benchmark results indicating a performance regression:
- Pull Request Run on `arm64-t4g-2xlarge-linux` at [2026-08-18 15:42:33Z](https://conbench.arrow-dev.org/compare/runs/0714fabd67174a3aad4e8d5548838dd3...86707244c8e8407d87e26fe47a57b136/)
- [`ThreadPoolSpawn` (C++) with params=threads:2/task_cost:100000/real_time, source=cpp-micro, suite=arrow-thread-pool-benchmark](https://conbench.arrow-dev.org/compare/benchmarks/06a8397ca11471558000211ae56744dc...06a847e0b55471d88000125b7a897aef)
- [`ThreadedTaskGroup` (C++) with params=threads:1/task_cost:100000/real_time, source=cpp-micro, suite=arrow-thread-pool-benchmark](https://conbench.arrow-dev.org/compare/benchmarks/06a8397cac2278cc8000493576f16099...06a847e0d3e274b08000da5b17666a8b)
- and 85 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/95849394649) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org