You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/01 16:24:06 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25992:
[SPARK-29320][TESTS] Compare `sql/core` module in JDK8/11 (Part 1)
dongjoon-hyun commented on a change in pull request #25992: [SPARK-29320][TESTS] Compare `sql/core` module in JDK8/11 (Part 1)
URL: https://github.com/apache/spark/pull/25992#discussion_r330151155
##########
File path: sql/core/benchmarks/ColumnarBatchBenchmark-jdk11-results.txt
##########
@@ -0,0 +1,59 @@
+================================================================================================
+Int Read/Write
+================================================================================================
+
+OpenJDK 64-Bit Server VM 11.0.4+11-LTS on Linux 3.10.0-862.3.2.el7.x86_64
+Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
+Int Read/Write: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
+------------------------------------------------------------------------------------------------------------------------
+Java Array 232 234 1 1409.7 0.7 1.0X
+ByteBuffer Unsafe 396 396 0 827.9 1.2 0.6X
+ByteBuffer API 602 603 0 544.0 1.8 0.4X
+DirectByteBuffer 1185 1186 2 276.6 3.6 0.2X
Review comment:
For JDK8, `DirectByteBuffer` took `743 (Best)` and `744 (Avg)`. JDK11 seems to be affected due to Apache Spark's `Platform.java` implementation which depends on `java.version` for now. How do you think about this?
cc @srowen and @wangyum .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org