[GitHub] [airflow] ashb commented on a change in pull request #16233: WIP: Fix TI success/failure links

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #16233:
URL: https://github.com/apache/airflow/pull/16233#discussion_r644621780



##########
File path: airflow/www/templates/airflow/ti_confirm.html
##########
@@ -0,0 +1,39 @@
+{#
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied.  See the License for the
+ specific language governing permissions and limitations
+ under the License.
+#}
+
+{% extends base_template %}
+
+{% block content %}

Review comment:
       What do we need a special confirm template for? (How is this different from our current confirm.html template?)

##########
File path: airflow/www/views.py
##########
@@ -1804,53 +1802,86 @@ def _mark_task_instance_state(  # pylint: disable=too-many-arguments
         latest_execution_date = dag.get_latest_execution_date()
         if not latest_execution_date:
             flash(f"Cannot make {state}, seem that dag {dag_id} has never run", "error")
-            return redirect(origin)
+            return redirect(request.referrer)

Review comment:
       Referrer is not always sent (some AV blocks it for instance) so we can't just do this.
   
   I also wonder if this makes it function as an open redirector of sorts




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org