You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/02/11 11:13:50 UTC

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs

bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs
URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r377558485
 
 

 ##########
 File path: libminifi/include/io/StreamFactory.h
 ##########
 @@ -90,8 +88,7 @@ class StreamFactory {
   }
 
  protected:
-
-  StreamFactory(const std::shared_ptr<Configure> &configure);
+  explicit StreamFactory(const std::shared_ptr<Configure> &configure);
 
 Review comment:
   This breaks API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services